Skip to content

refactor: Update wrong fluid fraction error message #3917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arng40 wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

refactor: Update wrong fluid fraction error message #3917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4124899
first pass of msg update
arng40 Nov 27, 2025
52fb7b1
add subregion name
arng40 Nov 27, 2025
f882a07
fix typo
arng40 Nov 27, 2025
be64432
Merge remote-tracking branch 'origin/develop' into fix/dudes/non-init…
arng40 Nov 27, 2025
bc5ac3d
fix wrong op Mpiwrapper
arng40 Nov 27, 2025
83d23f8
review
arng40 Dec 3, 2025
0b7a094
remove duplicated var
arng40 Dec 4, 2025
9a19c00
remove abs
arng40 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,10 @@ void CompositionalMultiphaseBase::initializeFluidState( MeshLevel & mesh,

{
RAJA::ReduceSum< parallelDeviceReduce, localIndex > localNegativeValues( 0 );
RAJA::ReduceSum< parallelDeviceReduce, localIndex > localWrongSum( 0 );
RAJA::ReduceSum< parallelDeviceReduce, localIndex > localTooHighFracCount( 0 );
RAJA::ReduceSum< parallelDeviceReduce, localIndex > localTooLowFracCount( 0 );
RAJA::ReduceMin< parallelDeviceReduce, localIndex > localMinFrac( LvArray::NumericLimits< localIndex >::max );
RAJA::ReduceMax< parallelDeviceReduce, localIndex > localMaxFrac( LvArray::NumericLimits< localIndex >::min );
forAll< parallelDevicePolicy<> >( subRegion.size(), [=] GEOS_HOST_DEVICE ( localIndex const ei )
{
real64 sumCompFrac = 0.0;
Expand All @@ -912,19 +915,32 @@ void CompositionalMultiphaseBase::initializeFluidState( MeshLevel & mesh,
if( compFrac[ei][ic] < 0.0 )
localNegativeValues += 1;
}
if( LvArray::math::abs( sumCompFrac - 1.0 ) > 1e-6 )
localWrongSum += 1;
localMinFrac.min( sumCompFrac );
localMaxFrac.max( sumCompFrac );
if( sumCompFrac > 1 + 1e-6 )
localTooHighFracCount += 1;
if( sumCompFrac < 1 - 1e-6 )
localTooLowFracCount += 1;
} );

localIndex const negativeValues = MpiWrapper::sum( localNegativeValues.get() );
GEOS_ERROR_IF( negativeValues > 0,
GEOS_FMT( "{}: negative global component fraction values found in subregion '{}' for {} elements",
getName(), subRegion.getName(), negativeValues ) );

localIndex const wrongSum = MpiWrapper::sum( localWrongSum.get() );
GEOS_ERROR_IF( wrongSum > 0,
GEOS_FMT( "{}: component fractions do not sum to 1.0 in subregion '{}' for {} elements",
getName(), subRegion.getName(), wrongSum ) );
localIndex const totalSupFrac = MpiWrapper::sum( localTooHighFracCount.get() );
localIndex const totalInfFrac = MpiWrapper::sum( localTooLowFracCount.get() );
localIndex const totalWrongCompFrac = totalSupFrac + totalInfFrac;
localIndex const minFrac = MpiWrapper::min( localMinFrac.get() );
localIndex const maxFrac = MpiWrapper::sum( localMaxFrac.get() );
GEOS_ERROR_IF( totalWrongCompFrac > 0,
GEOS_FMT( "{} component fractions do not sum to 1.0 in subregion '{}'!\n"
"{} are too low ; {} are too high ; component fractions sum range is from {} to {}.\n"
"Consider adding field specification to initialize the '{}' field.",
totalWrongCompFrac, subRegion.getName(),
localTooLowFracCount.get(), localTooHighFracCount.get(), minFrac, maxFrac,
fields::flow::globalCompFraction::key() ),
getDataContext());
}

// Assume global component fractions have been prescribed.
Expand Down
Loading
Loading