-
Notifications
You must be signed in to change notification settings - Fork 0
ci: Update CI to include new packages, typing and tests #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add pytest, mypy, and linting actions for selected packages
add pytest, mypy, and linting actions for selected packages
…tests_ruff_mypy Add install package for vtk in test action Set mypy and pytest in python-package action
|
@CusiniM if you have a moment, can you check everything is ok at least in geos-ats, geos-mesh and the CI configuration? |
|
Is it possible to add this step in the CI. Adding conventional semantics checking will ease packaging. You'll be able to add automatic package numbering for deployment based on the work you are doing now. |
|
As a more modern approach I would recommend to keep the mypy section in the pyproject.toml. Mypy will look for it's configuration in this file |
I choose to add a .mypy.ini file to ensure that all the packages follow the same typing rules (similarly to linting approach using the .style.yml file). @untereiner do you mean to define typing (and linting) rules in a pyproject.toml file in the root directory in addition to the pyproject.toml in each package directory? |
|
Ok you are right. Not sure it is possible to have a root pyproject only for mypy and linting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing the question of python version in the infrastructure meeting, @CusiniM told me that you could build GEOS with your own python version as long as your pygeos uses the same. So there is no limitation of a specific 3.9 version as I thought. So using 3.10 as a baseline is okay.
|
@alexbenedicto The warning in the doc does not prevent building it but I agree it is a bit annoying. I tried to fix it by installing additional packages (from Google research) but it still appeared (this commit). |
|
@untereiner do you have any additional comments or are you ok with the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !

Closes #58
This PR add tests and type checking in the CI. The work done includes:
Future work: