[Enhancement]Stereo Playout integration #994
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ipavlidakis
force-pushed
the
enhancement/hifi/stereo-playout-3
branch
from
e2db509 to
e2b021e
Compare
Public Interface- public struct AudioSessionConfiguration: ReflectiveStringConvertible, Equatable, Sendable
+ public struct AudioSessionConfiguration: CustomStringConvertible, Equatable, Sendable
- public static func ==(lhs: Self,rhs: Self)-> Bool
+ public var description: String
+
+
+ public static func ==(lhs: Self,rhs: Self)-> Bool |
Collaborator
SDK Size
|
Collaborator
StreamVideo XCSize
Show 91 more objects
|
Collaborator
StreamVideoSwiftUI XCSize
|
ipavlidakis
force-pushed
the
enhancement/hifi/stereo-playout-3
branch
from
86c4c5f to
3b8bd28
Compare
ipavlidakis
force-pushed
the
enhancement/hifi/feature-implementation
branch
from
ebfedd9 to
6b6c886
Compare
# Conflicts: # StreamVideo.xcodeproj/project.pbxproj
ipavlidakis
force-pushed
the
enhancement/hifi/stereo-playout-3
branch
from
3885f72 to
275c58d
Compare
|
|
||
| static var proximityPolicies: Set<ProximityPolicyDebugConfiguration> = { | ||
| [.speaker, .video] | ||
| [] |
Contributor
There was a problem hiding this comment.
is this affecting stereo?
| /// Category options for playback. | ||
| static let playback: AVAudioSession.CategoryOptions = [] | ||
|
|
||
| #if !canImport(AVFoundation, _version: 2360.61.4.11) |
Contributor
There was a problem hiding this comment.
this is a bit ugly, and potentially error prone, can we have another way?
| static let playback: AVAudioSession.CategoryOptions = [] | ||
|
|
||
| #if !canImport(AVFoundation, _version: 2360.61.4.11) | ||
| public static let allowBluetoothHFP = Self.allowBluetooth |
Contributor
There was a problem hiding this comment.
I read this about HFP: "if your app is for high-quality audio (music, streaming, etc.), HFP is undesirable because it degrades audio quality."
Will it have impact on audio quality?
| options.append(".duckOthers") | ||
| } | ||
|
|
||
| #if canImport(AVFoundation, _version: 2360.61.4.11) |
| mode: .voiceChat, | ||
| options: [ | ||
| .allowBluetooth, | ||
| .allowBluetoothHFP, |
Contributor
There was a problem hiding this comment.
should this be default?
| self.routeSharingPolicy = source.routeSharingPolicy | ||
| self.availableModes = source.availableModes | ||
| self.preferredInput = source.preferredInput.map { .init($0) } ?? nil | ||
| if #available(iOS 17.2, *) { self.renderingMode = "\(source.renderingMode)" } |
Contributor
There was a problem hiding this comment.
we should test this stuff on older iOS versions
| shouldRecord: false, | ||
| isRecording: false, | ||
| isMicrophoneMuted: false, | ||
| isMicrophoneMuted: true, |
Contributor
There was a problem hiding this comment.
why do we change this?
| _ = audioDeviceModule | ||
| PeerConnectionFactoryStorage.shared.store(self, for: audioProcessingModule) | ||
| // Remove caching | ||
| // PeerConnectionFactoryStorage.shared.store(self, for: audioProcessingModule) |
Contributor
There was a problem hiding this comment.
should we delete this instead?
| try await setLocalDescription(answer) | ||
| var answer = try await createAnswer() | ||
| if mungeSubscriberStereo { | ||
| let munger = SDPParser() |
Contributor
There was a problem hiding this comment.
when's this going to be enabled on the backend so we can remove this code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Provide all JIRA tickets and/or GitHub issues related to this PR, if applicable.
🎯 Goal
Describe why we are making this change.
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
TODO
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
imgimg🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
🎁 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)