-
Notifications
You must be signed in to change notification settings - Fork 30
[Enhancement]Stereo Playout integration #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ipavlidakis
wants to merge
42
commits into
enhancement/hifi/feature-implementation
Choose a base branch
from
enhancement/hifi/stereo-playout-3
base: enhancement/hifi/feature-implementation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,533
−1,184
Draft
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
108e3ac
Use local webrtc
ipavlidakis fea0818
Implement StereoPlayoutAvailability reducer
ipavlidakis ca73238
Implement StoreEffects
ipavlidakis 6c2ffd7
Improve audioOutput preference
ipavlidakis 31b975b
Update to webrtc 137.1.0
ipavlidakis 86bfbba
WIP
ipavlidakis f32d034
Restart playout whenever the currentRoute changes
ipavlidakis e0cba0a
SDP Munge workaround
ipavlidakis ae83da1
Update webrtc version
ipavlidakis 3f83954
Add missing files
ipavlidakis d8d9b99
Clean up session once the call has ended
ipavlidakis 1f5d5f3
Add reason to the AudioRoute
ipavlidakis 1f70f70
Ensure there is always audio playback
ipavlidakis 6c9ef01
Ensure stereo playout between device changes
ipavlidakis 7a6b06a
Improve the routeChange reporting
ipavlidakis 017f577
Update webrtc version to 137.0.45
ipavlidakis e21de6a
Log improvement
ipavlidakis 1a40dad
Add missing reducer handling for stereo
ipavlidakis cc7b5b0
Remove unnecessary method
ipavlidakis f06bd2e
Small logging update
ipavlidakis 22fde19
Solidify route transition (with stereo playout disabled)
ipavlidakis c49c938
Clean up
ipavlidakis 6124042
Implement LIvestreamAudioSessionPolicy
ipavlidakis 0771f0a
Solidify route change observation without stereo
ipavlidakis c4fbce6
StereoPlayout stability
ipavlidakis 1ff421c
AudioSessionObserver
ipavlidakis f63c2fc
Improve route selection on init
ipavlidakis cb0e7ab
allowBluetoothHFP always (resolve warning)
ipavlidakis 01ca136
Increase debounce time on StereoPlayout availability
ipavlidakis 27d71af
Update to 137.0.46 and improve stereoPlayout control
ipavlidakis 8f1e74a
Improvements
ipavlidakis 275c58d
update webrtc to 137.0.48
ipavlidakis 49325bb
Improvements
ipavlidakis ba806a2
Improve logging
ipavlidakis f068eb9
Update webrtc to 137.0.50
ipavlidakis 4737e4d
Add comments
ipavlidakis 090378f
Further improvements
ipavlidakis 122be21
Fixes and update to webrtc 137.0.51
ipavlidakis 6844c5d
Fix enable/disable audioOutput
ipavlidakis 213f75f
Add comment
ipavlidakis 853bfb5
Clean up
ipavlidakis c085841
Fix compilation issues on tests and mocks
ipavlidakis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
345 changes: 304 additions & 41 deletions
345
Sources/StreamVideo/Utils/AudioSession/AudioDeviceModule/AudioDeviceModule.swift
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this affecting stereo?