feat(email_worker): refine sender logic and event types #2144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the email worker's sender logic to handle delivery robustly and extends
event types to propagate necessary context (ChannelID and Event IDs).
Changes:
- **Event Types**: Added `ChannelID` to `EmailJobEvent` to ensure the consumer
can identify the target channel.
- **Worker Types**: Introduced `IncomingEmailDeliveryJob` to capture the
`EmailEventID` (Pub/Sub message ID) for audit logging. Added sentinel errors
(`ErrUnrecoverableUserFailureEmailSending`, `ErrUnrecoverableSystemFailureEmailSending`)
to distinguish failure modes.
- **Sender Logic**: Refactored `ProcessMessage` to:
- Use `IncomingEmailDeliveryJob` for better context.
- Handle distinct error types: Permanent user errors are recorded and ACKed;
transient errors trigger NACKs for retry.
- Pass `EmailEventID` and error classification to the `ChannelStateManager`
for precise attempt tracking.
- **Pub/Sub Adapter**: Added logging to `PublishEmailJob` to trace published IDs.
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt3
branch
from
b9da33d to
f9040df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the email worker's sender logic to handle delivery robustly and extends event types to propagate necessary context (ChannelID and Event IDs).
Changes:
ChannelIDtoEmailJobEventto ensure the consumer can identify the target channel.IncomingEmailDeliveryJobto capture theEmailEventID(Pub/Sub message ID) for audit logging. Added sentinel errors (ErrUnrecoverableUserFailureEmailSending,ErrUnrecoverableSystemFailureEmailSending) to distinguish failure modes.ProcessMessageto:IncomingEmailDeliveryJobfor better context.EmailEventIDand error classification to theChannelStateManagerfor precise attempt tracking.PublishEmailJobto trace published IDs.