DropDown menu in MainTable rows

[K1-mbf]

Closes #14087

This issue consisted of adding a drop-down menu to the custom fields of the main table for changing the attributes. Something similar already existed for the view field.

Steps to test

I followed the same steps as described in the issue:

1. Create a new library demo.bib
2. Add a new entry
3. In BibTeX source, add icore = {abc}

@Article{demo,
icore = {abc}
}

4. Open Library properties
5. Add Content selectors for ICORE

6. Go to File > Preferences > Entry table
7. Add the custom column ICORE

8. Save and restart JabRef

9. Now, when you click on the field, you can change its value

10. You can click on any keyword you want, and it will update the value

Mandatory checks

• I own the copyright of the code submitted and I license it under the MIT license
• I manually tested my changes in running JabRef (always required)
• I added JUnit tests for changes (if applicable)
• I added screenshots in the PR description (if the change is visible to the user)
• I described the change in CHANGELOG.md in a way that is understandable for the average user (if the change is visible to the user)
• I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or submitted a pull request updating the relevant files in https://github.com/JabRef/user-documentation/tree/main/en.

[github-actions]

Hey @K1-mbf!

Thank you for contributing to JabRef! Your help is truly appreciated ❤️

We have automated checks in place, based on which you will soon get feedback if any of them are failing. In a while, maintainers will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

[calixtus]

could maybe a helper method for clean code: isContentSelectorField or sthg.

[K1-mbf]

Hello @calixtus,
the only way I can figure out a solution is by doing:

private List<String> getValueFromField(Field field){
        return database.getMetaData().getContentSelectorValuesForField(field);
    }

if (!column.getQualifier().isBlank()) {
                    Field field = FieldFactory.parseField(column.getQualifier());
                    List<String> values = getValueFromField(field);

                    if (values != null && !values.isEmpty()) {

but this solution is not the same helper method.

or :

private boolean isContentSelectorField(List<String> values){
        return values != null && !values.isEmpty();
    }

if (!column.getQualifier().isBlank()) {
    Field field = FieldFactory.parseField(column.getQualifier());
    List<String> values = database.getMetaData().getContentSelectorValuesForField(field);

    if (isContentSelectorField(values)) {

or :

private boolean isContentSelectorField(Field field){
        List<String> values = database.getMetaData().getContentSelectorValuesForField(field);
        return values != null && !values.isEmpty();
    }

if (!column.getQualifier().isBlank()) {
                    Field field = FieldFactory.parseField(column.getQualifier());
                    
                    if (isContentSelectorField(field)) {
                        List<String> values = database.getMetaData().getContentSelectorValuesForField(field);
                        returnColumn = createContentSelectorColumn(column, values);

but this solution means that we calculate the values twice.

Can you tell me what you meant by your request, because I can't figure out anything without drawbacks

[calixtus]

oh no, this was a bit misunderstandable. I just meant to extract the predicate in the if clause (values != null && !values.isEmpty()) to a method called isContentSelectorField.

[calixtus]

but maybe we just let it go to avoid recalculation.

[calixtus]

small nitpicks

[koppor]

@K1-mbf Please address the review comments.

[calixtus]

I put it into the merge queue. Thanks for your contribution. We would love to see more 😍