-
Notifications
You must be signed in to change notification settings - Fork 6.1k
KT-20357: Add sample usages for array constructor functions #5521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oscarArismendi
wants to merge
3
commits into
JetBrains:master
Choose a base branch
from
oscarArismendi:KT-20357-array-of-samples
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+140
−0
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
a166b7e
KT-20357: Add sample usages for array constructor functions in standa…
oscarArismendi a74af86
KT-20357: Rename and enhance sample usages for array constructor func…
oscarArismendi b49f96e
KT-20357: Add sample for arrayOf function in standard library
oscarArismendi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,46 +28,64 @@ public expect fun <reified T> arrayOfNulls(size: Int): Array<T?> | |
|
|
||
| /** | ||
| * Returns an array containing the specified elements. | ||
| * | ||
| * @sample samples.collections.Arrays.Constructors.arrayOfSample | ||
| */ | ||
| public expect inline fun <reified T> arrayOf(vararg elements: T): Array<T> | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It also makes sense to add a similar sample for
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done on b49f96e |
||
| /** | ||
| * Returns an array containing the specified [Double] numbers. | ||
| * | ||
| * @sample samples.collections.Arrays.Constructors.doubleArrayOfSample | ||
| */ | ||
| public expect fun doubleArrayOf(vararg elements: Double): DoubleArray | ||
|
|
||
| /** | ||
| * Returns an array containing the specified [Float] numbers. | ||
| * | ||
| * @sample samples.collections.Arrays.Constructors.floatArrayOfSample | ||
| */ | ||
| public expect fun floatArrayOf(vararg elements: Float): FloatArray | ||
|
|
||
| /** | ||
| * Returns an array containing the specified [Long] numbers. | ||
| * | ||
| * @sample samples.collections.Arrays.Constructors.longArrayOfSample | ||
| */ | ||
| public expect fun longArrayOf(vararg elements: Long): LongArray | ||
|
|
||
| /** | ||
| * Returns an array containing the specified [Int] numbers. | ||
| * | ||
| * @sample samples.collections.Arrays.Constructors.intArrayOfSample | ||
| */ | ||
| public expect fun intArrayOf(vararg elements: Int): IntArray | ||
|
|
||
| /** | ||
| * Returns an array containing the specified characters. | ||
| * | ||
| * @sample samples.collections.Arrays.Constructors.charArrayOfSample | ||
| */ | ||
| public expect fun charArrayOf(vararg elements: Char): CharArray | ||
|
|
||
| /** | ||
| * Returns an array containing the specified [Short] numbers. | ||
| * | ||
| * @sample samples.collections.Arrays.Constructors.shortArrayOfSample | ||
| */ | ||
| public expect fun shortArrayOf(vararg elements: Short): ShortArray | ||
|
|
||
| /** | ||
| * Returns an array containing the specified [Byte] numbers. | ||
| * | ||
| * @sample samples.collections.Arrays.Constructors.byteArrayOfSample | ||
| */ | ||
| public expect fun byteArrayOf(vararg elements: Byte): ByteArray | ||
|
|
||
| /** | ||
| * Returns an array containing the specified boolean values. | ||
| * | ||
| * @sample samples.collections.Arrays.Constructors.booleanArrayOfSample | ||
| */ | ||
| public expect fun booleanArrayOf(vararg elements: Boolean): BooleanArray | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense to showcase that these functions produce an empty array when invoked without any arguments. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Samples for array functions have been added as requested(Ref a74af86). I renamed the sample methods with a 'Sample' suffix to prevent recursive self-calls, but let me know what you think