Convert to be a ROS-agnostic pure-CMake package #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clearly I'll need to make some changes to help CI succeed. |
|
Can I merge #11 before you complete this? |
I think that makes sense. There's certainly some overlap between the two PRs. |
schornakj
force-pushed
the
feature/pure-cmake
branch
from
088fd8b to
1b1d855
Compare
This was referenced May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using this package for a variety of ROS 2 projects. It ended up being fairly straightforward to convert the package to be a non-ROS pure-CMake package, which lets us use the package in both ROS and ROS 2 projects. I also modified it to follow "modern" CMake conventions, such as exporting a
gl_depth_sim::gl_depth_simtarget that downstream projects can conveniently link against.The main thing that breaks is the
camera_ros_example.cppdemo, since it fundamentally requires a ROS node. If we want to keep that demo we could create optional sub-packages that are conditionally built depending on the detected ROS version, like theros_scxmlproject does for its demos.