Skip to content

fix show of self referential arrays #58863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 20, 2025
Merged

fix show of self referential arrays #58863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3ace4b
fix == and show on self-referential arrays
adienes Jul 1, 2025
a857150
punt on equality changes
adienes Jul 1, 2025
7f92f5f
remove test_brokens
adienes Jul 8, 2025
0837266
Merge branch 'master' into selfrefarray_fixes
adienes Aug 13, 2025
3366443
Merge branch 'master' of https://github.com/JuliaLang/julia into self…
adienes Aug 14, 2025
45ecf39
Merge branch 'master' into selfrefarray_fixes
adienes Aug 15, 2025
3b3f28c
don't check each element
adienes Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions base/arrayshow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,9 +488,12 @@ function show(io::IO, X::AbstractArray)
if !implicit
io = IOContext(io, :typeinfo => eltype(X))
end
isempty(X) ?
_show_empty(io, X) :
_show_nonempty(io, X, prefix)
if isempty(X)
return _show_empty(io, X)
end
show_circular(io, X) && return
recur_io = IOContext(io, :SHOWN_SET => X)
_show_nonempty(recur_io, X, prefix)
end

### 0-dimensional arrays (#31481)
Expand Down
18 changes: 18 additions & 0 deletions test/abstractarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2316,3 +2316,21 @@ end
v2 = view(A, Base.IdentityUnitRange(1:length(A)))
@test sum(x for x in v2) == sum(A)
end

@testset "self referential" begin
v = Any[1,2,3]
v[1] = v
io = IOBuffer()
show(io, v)
@test String(take!(io)) == "Any[Any[#= circular reference @-1 =#], 2, 3]"

m1 = Any[1 2; 3 4]
m1[1] = m1
show(io, m1)
@test String(take!(io)) == "Any[#= circular reference @-1 =# 2; 3 4]"

m2 = Any[1; 2;; 3; 4;;; 5; 6;; 7; 8]
m2[1] = m2
show(io, m2)
@test String(take!(io)) == "Any[#= circular reference @-1 =# 3; 2 4;;; 5 7; 6 8]"
end