Skip to content

Fix objcons! for SimpleNLSModel #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 4, 2025
Merged

Conversation

arnavk23
Copy link
Contributor

Closes #443

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arnavk23 ! Thanks for having a look at this issue. I added more information in the issue. It's not about modifying SimpleNLSModel.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnavk23 ! I proposed a small refactoring

arnavk23 and others added 3 commits July 29, 2025 19:15
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
@arnavk23 arnavk23 requested a review from tmigot July 29, 2025 13:54
@arnavk23 arnavk23 requested a review from tmigot July 31, 2025 16:47
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnavk23 You asked for a new review, but none of my last comments were adressed in the last commit 58e7df4

arnavk23 and others added 3 commits August 4, 2025 18:03
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
@tmigot tmigot merged commit 80bf4aa into JuliaSmoothOptimizers:main Aug 4, 2025
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

objcons! with in-place residual not defined for NLS
2 participants