Skip to content

Fix objcons! for SimpleNLSModel #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 4, 2025
Merged

Fix objcons! for SimpleNLSModel #507

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b8f5e7d
Fix objcons! for SimpleNLSModel to match test expectations: constrain…
arnavk23 Jul 28, 2025
d989111
Merge branch 'JuliaSmoothOptimizers:main' into main
arnavk23 Jul 28, 2025
33766c7
Add dual objcons! signatures for SimpleNLSModel to support new Abstra…
arnavk23 Jul 28, 2025
e46d1a9
objcons
arnavk23 Jul 28, 2025
f2df725
Update src/nls/api.jl
arnavk23 Jul 29, 2025
fa4527c
Update src/nls/api.jl
arnavk23 Jul 29, 2025
f5128c4
Update simple-model.jl
arnavk23 Jul 29, 2025
58e7df4
changes to the NLS API and a simple model test
arnavk23 Jul 31, 2025
57d7829
Update src/nls/api.jl
arnavk23 Aug 4, 2025
9763d2a
Update src/nls/api.jl
arnavk23 Aug 4, 2025
5ed26da
Update test/nls/simple-model.jl
arnavk23 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions test/nls/simple-model.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,37 @@ end

SimpleNLSModel() = SimpleNLSModel(Float64)

# In-place objcons! for NLS
function NLPModels.objcons!(nls::SimpleNLSModel, x::AbstractVector, Fx::AbstractVector)
@lencheck nls.meta.ncon Fx
NLPModels.cons_nln!(nls, x, Fx)
res = [1 - x[1]; 10 * (x[2] - x[1]^2)]
f = 0.5 * sum(abs2, res)
return f, Fx
end

function NLPModels.jprod(nls::SimpleNLSModel, x::AbstractVector, v::AbstractVector)
Jv = similar(v, nls.meta.ncon)
NLPModels.jprod!(nls, x, v, Jv)
return Jv
end

function NLPModels.jprod(nls::SimpleNLSModel, v::AbstractVector)
Jv = similar(v, nls.meta.ncon)
NLPModels.jprod!(nls, v, Jv)
return Jv
end

function NLPModels.jprod!(nls::SimpleNLSModel, v::AbstractVector, Jv::AbstractVector)
NLPModels.jprod_nln!(nls, nls.meta.x0, v, Jv)
return Jv
end

function NLPModels.jprod!(nls::SimpleNLSModel, x::AbstractVector, v::AbstractVector, Jv::AbstractVector)
NLPModels.jprod_nln!(nls, x, v, Jv)
return Jv
end

function NLPModels.residual!(nls::SimpleNLSModel, x::AbstractVector, Fx::AbstractVector)
@lencheck 2 x Fx
increment!(nls, :neval_residual)
Expand Down