Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

speediedan
Copy link
Contributor

  • Validated (locally) the Fine-Tuning Scheduler (FTS) tutorial for FTS/Lightning/PyTorch 2.5.0.
  • Prepared for HF clean_up_tokenization_spaces behavior change,
  • Added reference to FTS enhanced support for ModelParallelStrategy enabling use of PyTorch composable distributed (e.g. fully_shard, checkpoint) and Tensor Parallelism (TP) APIs

Thank you for all your work and your consistently valuable contributions to the open-source ML community!

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Updates the Fine-Tuning Scheduler tutorial to prepare for 2.5.0 tutorial publishing.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

…zation_spaces` behavior change, add reference to FTS enhanced support for `ModelParallelStrategy` enabling use of PyTorch composable distributed (e.g. ``fully_shard``, ``checkpoint``) and Tensor Parallelism (TP) APIs, temporarily disable docformatter pre-commit hook until an outstanding fix is merged
@mergify mergify bot requested a review from Borda December 20, 2024 20:53
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (a7d9471) to head (afb0428).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #372   +/-   ##
===================================
  Coverage    69%    69%           
===================================
  Files         2      2           
  Lines       441    441           
===================================
  Hits        306    306           
  Misses      135    135           

@speediedan speediedan marked this pull request as ready for review December 20, 2024 21:04
@Borda Borda merged commit 1eb64a1 into Lightning-AI:main Dec 22, 2024
16 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants