Skip to content

chore: docker image updates #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2025
Merged

chore: docker image updates #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6fd244
#429: updated minio and mongo images
basmasking Jul 26, 2025
cbb47a5
#429: removed unused asset from the assets whitelist
basmasking Jul 26, 2025
31f3817
Merge branch 'main' into 429-update-minio-config
basmasking Jul 26, 2025
38b4a04
#429: update minio config to match env variables
basmasking Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ volumes:
services:

mongo:
image: mongo:8.0.4
image: mongo:8.0.12
restart: always
volumes:
- comify-mongo-data:/data/db
Expand All @@ -31,16 +31,16 @@ services:
ME_CONFIG_MONGODB_URL: "mongodb://${MONGODB_ROOT_USERNAME}:${MONGODB_ROOT_PASSWORD}@mongo:27017/"

minio:
image: minio/minio:RELEASE.2025-02-07T23-21-09Z
image: minio/minio:RELEASE.2025-07-23T15-54-02Z
restart: always
volumes:
- comify-minio-data:/data
ports:
- "${MINIO_PORT_NUMBER:-9000}:9000"
- "${MINIO_ADMIN_PORT_NUMBER:-9001}:9001"
environment:
MINIO_ACCESS_KEY: ${MINIO_ACCESS_KEY}
MINIO_SECRET_KEY: ${MINIO_SECRET_KEY}
MINIO_ROOT_USER: ${MINIO_ROOT_USER}
MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD}
command: server --console-address ":9001" /data
Comment on lines +34 to 44
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Switched to MINIO_ROOT_USER/PASSWORD – clean up legacy vars & fix indent

  1. MINIO_ACCESS_KEY/SECRET_KEY are now deprecated; remove them from example.env to avoid operator confusion.
  2. YAML-lint flags incorrect indentation (lines 33-42). Two-space levels would silence the warning.

Example tidy-up:

-    image: minio/minio:RELEASE.2025-07-23T15-54-02Z
+      image: minio/minio:RELEASE.2025-07-23T15-54-02Z
...
-      MINIO_ROOT_USER: ${MINIO_ROOT_USER}
-      MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD}
+        MINIO_ROOT_USER: ${MINIO_ROOT_USER}
+        MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
image: minio/minio:RELEASE.2025-07-23T15-54-02Z
restart: always
volumes:
- comify-minio-data:/data
ports:
- "${MINIO_PORT_NUMBER:-9000}:9000"
- "${MINIO_ADMIN_PORT_NUMBER:-9001}:9001"
environment:
MINIO_ACCESS_KEY: ${MINIO_ACCESS_KEY}
MINIO_SECRET_KEY: ${MINIO_SECRET_KEY}
MINIO_ROOT_USER: ${MINIO_ROOT_USER}
MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD}
command: server --console-address ":9001" /data
image: minio/minio:RELEASE.2025-07-23T15-54-02Z
restart: always
volumes:
- comify-minio-data:/data
ports:
- "${MINIO_PORT_NUMBER:-9000}:9000"
- "${MINIO_ADMIN_PORT_NUMBER:-9001}:9001"
environment:
MINIO_ROOT_USER: ${MINIO_ROOT_USER}
MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD}
command: server --console-address ":9001" /data
🧰 Tools
🪛 YAMLlint (1.37.1)

[warning] 33-33: wrong indentation: expected 6 but found 4

(indentation)

[warning] 36-36: wrong indentation: expected 8 but found 6

(indentation)

[warning] 38-38: wrong indentation: expected 8 but found 6

(indentation)

[warning] 41-41: wrong indentation: expected 8 but found 6

(indentation)

🤖 Prompt for AI Agents 
In docker-compose.yml lines 33 to 43, remove any legacy environment variables
MINIO_ACCESS_KEY and MINIO_SECRET_KEY from example.env to avoid confusion, and
fix the indentation of the environment section to use consistent two-space
indentation for all keys and values to comply with YAML linting rules.


keycloak:
Expand Down
4 changes: 2 additions & 2 deletions example.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ FILE_STORE_IMPLEMENTATION="minio"
MINIO_END_POINT="localhost"
MINIO_PORT_NUMBER=9000
MINIO_USE_SSL=false
MINIO_ACCESS_KEY="development"
MINIO_SECRET_KEY="development"
MINIO_ROOT_USER="development"
MINIO_ROOT_PASSWORD="development"

# AUTHENTICATION (openid)
AUTHENTICATION_CLIENT_PATH="/identify"
Expand Down
2 changes: 1 addition & 1 deletion services/repository.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"repository":
{
"serveIndexOnNotFound": true,
"assets": ["index.html", "main.js", "assets/**/*", "webui/**/*", "registerSW.js", "sw.js", "workbox-*.js", "manifest.webmanifest" ]
"assets": ["index.html", "assets/**/*", "webui/**/*", "registerSW.js", "sw.js", "workbox-*.js", "manifest.webmanifest" ]
}
}
2 changes: 1 addition & 1 deletion services/standalone.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
"segments": ["bff", "notification", "reads", "writes"],

"serveIndexOnNotFound": true,
"assets": ["index.html", "main.js", "assets/**/*", "webui/**/*", "registerSW.js", "sw.js", "workbox-*.js", "manifest.webmanifest" ]
"assets": ["index.html", "assets/**/*", "webui/**/*", "registerSW.js", "sw.js", "workbox-*.js", "manifest.webmanifest" ]
}
}
4 changes: 2 additions & 2 deletions src/integrations/filestore/implementations/minio/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ export default function create(): MinioFS
const endPoint = process.env.MINIO_END_POINT ?? 'undefined';
const port = Number(process.env.MINIO_PORT_NUMBER ?? 9000);
const useSSL = process.env.MINIO_USE_SSL === 'true';
const accessKey = process.env.MINIO_ACCESS_KEY ?? 'undefined';
const secretKey = process.env.MINIO_SECRET_KEY ?? 'undefined';
const accessKey = process.env.MINIO_ROOT_USER ?? 'undefined';
const secretKey = process.env.MINIO_ROOT_PASSWORD ?? 'undefined';

return new MinioFS({ endPoint, port, useSSL, accessKey, secretKey });
}