chore: docker image updates #430
Conversation
Summary by CodeRabbit
WalkthroughThe changes update service image versions for MongoDB and MinIO in the Docker Compose configuration, adjust MinIO environment variable keys to use current standards, and update example environment variables accordingly. Additionally, "main.js" is removed from asset lists in two JSON configuration files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docker-compose.yml(2 hunks)example.env(1 hunks)services/repository.json(1 hunks)services/standalone.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
services/standalone.json (1)
Learnt from: basmasking
PR: #412
File: segments/writes.json:23-23
Timestamp: 2025-05-23T20:57:56.396Z
Learning: Segmentation files in the Comify project support index resolution. When a path like ./domain/post.metrics/update is referenced in segment configuration files, it implicitly refers to ./domain/post.metrics/update/index.ts (or similar extension).
🪛 YAMLlint (1.37.1)
docker-compose.yml
[warning] 8-8: wrong indentation: expected 6 but found 4
(indentation)
[warning] 33-33: wrong indentation: expected 6 but found 4
(indentation)
[warning] 36-36: wrong indentation: expected 8 but found 6
(indentation)
[warning] 38-38: wrong indentation: expected 8 but found 6
(indentation)
[warning] 41-41: wrong indentation: expected 8 but found 6
(indentation)
🔇 Additional comments (3)
services/repository.json (1)
6-6: ‘main.js’ removal – double-check asset references
main.jsused to be the default Vite/Angular/Webpack entry point. Ensure that:
index.htmlno longer contains a hard-coded<script src="main.js">(or similar) tag.- Any runtime that expects
main.js(service-worker preload lists, CSP manifests, etc.) has been updated.Otherwise 404s will occur in production.
services/standalone.json (1)
25-25: Same asset removal for standalone build – verify parityThe standalone bundle must also be audited for stale references to
main.js; otherwise the gateway may serve an incomplete SPA.docker-compose.yml (1)
8-16: MongoDB 8.0.12 upgrade – confirm driver & data-file compatibilityGoing from 8.0.4 → 8.0.12 is usually safe, but it is still a minor bump that may pull in WiredTiger or auth-mechanism changes.
Run the integration tests and validate that:• the application drivers negotiate the same SCRAM mechanism
• existing data volumes migrate without error messages in the Mongo logs
| image: minio/minio:RELEASE.2025-07-23T15-54-02Z | ||
| restart: always | ||
| volumes: | ||
| - comify-minio-data:/data | ||
| ports: | ||
| - "${MINIO_PORT_NUMBER:-9000}:9000" | ||
| - "${MINIO_ADMIN_PORT_NUMBER:-9001}:9001" | ||
| environment: | ||
| MINIO_ACCESS_KEY: ${MINIO_ACCESS_KEY} | ||
| MINIO_SECRET_KEY: ${MINIO_SECRET_KEY} | ||
| MINIO_ROOT_USER: ${MINIO_ROOT_USER} | ||
| MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD} | ||
| command: server --console-address ":9001" /data |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Switched to MINIO_ROOT_USER/PASSWORD – clean up legacy vars & fix indent
MINIO_ACCESS_KEY/SECRET_KEYare now deprecated; remove them fromexample.envto avoid operator confusion.- YAML-lint flags incorrect indentation (lines 33-42). Two-space levels would silence the warning.
Example tidy-up:
- image: minio/minio:RELEASE.2025-07-23T15-54-02Z
+ image: minio/minio:RELEASE.2025-07-23T15-54-02Z
...
- MINIO_ROOT_USER: ${MINIO_ROOT_USER}
- MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD}
+ MINIO_ROOT_USER: ${MINIO_ROOT_USER}
+ MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| image: minio/minio:RELEASE.2025-07-23T15-54-02Z | |
| restart: always | |
| volumes: | |
| - comify-minio-data:/data | |
| ports: | |
| - "${MINIO_PORT_NUMBER:-9000}:9000" | |
| - "${MINIO_ADMIN_PORT_NUMBER:-9001}:9001" | |
| environment: | |
| MINIO_ACCESS_KEY: ${MINIO_ACCESS_KEY} | |
| MINIO_SECRET_KEY: ${MINIO_SECRET_KEY} | |
| MINIO_ROOT_USER: ${MINIO_ROOT_USER} | |
| MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD} | |
| command: server --console-address ":9001" /data | |
| image: minio/minio:RELEASE.2025-07-23T15-54-02Z | |
| restart: always | |
| volumes: | |
| - comify-minio-data:/data | |
| ports: | |
| - "${MINIO_PORT_NUMBER:-9000}:9000" | |
| - "${MINIO_ADMIN_PORT_NUMBER:-9001}:9001" | |
| environment: | |
| MINIO_ROOT_USER: ${MINIO_ROOT_USER} | |
| MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD} | |
| command: server --console-address ":9001" /data |
🧰 Tools
🪛 YAMLlint (1.37.1)
[warning] 33-33: wrong indentation: expected 6 but found 4
(indentation)
[warning] 36-36: wrong indentation: expected 8 but found 6
(indentation)
[warning] 38-38: wrong indentation: expected 8 but found 6
(indentation)
[warning] 41-41: wrong indentation: expected 8 but found 6
(indentation)
🤖 Prompt for AI Agents
In docker-compose.yml lines 33 to 43, remove any legacy environment variables
MINIO_ACCESS_KEY and MINIO_SECRET_KEY from example.env to avoid confusion, and
fix the indentation of the environment section to use consistent two-space
indentation for all keys and values to comply with YAML linting rules.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
docker-compose.yml (1)
34-44: Fix indentation and replace legacy MinIO env varsThe MinIO service block in
docker-compose.ymlneeds its indentation corrected, and there are still references to the oldMINIO_ACCESS_KEY/MINIO_SECRET_KEYelsewhere that must be updated toMINIO_ROOT_USER/MINIO_ROOT_PASSWORD.Diff for docker-compose.yml (around lines 34–44):
services: minio: - image: minio/minio:RELEASE.2025-07-23T15-54-02Z + image: minio/minio:RELEASE.2025-07-23T15-54-02Z - restart: always - volumes: + restart: always + volumes: - comify-minio-data:/data - ports: + ports: - "${MINIO_PORT_NUMBER:-9000}:9000" - "${MINIO_ADMIN_PORT_NUMBER:-9001}:9001" - environment: - MINIO_ROOT_USER: ${MINIO_ROOT_USER} - MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD} - command: server --console-address ":9001" /data + environment: + MINIO_ROOT_USER: ${MINIO_ROOT_USER} + MINIO_ROOT_PASSWORD: ${MINIO_ROOT_PASSWORD} + command: server --console-address ":9001" /dataOther locations to update:
example.env: remove or replace the commented-outMINIO_ACCESS_KEY/MINIO_SECRET_KEYentries with the new vars.src/integrations/filestore/implementations/minio/create.ts: switch fromprocess.env.MINIO_ACCESS_KEY/MINIO_SECRET_KEYtoprocess.env.MINIO_ROOT_USER/MINIO_ROOT_PASSWORD.docs/integrations/FILE_STORE.md: update examples to useMINIO_ROOT_USERandMINIO_ROOT_PASSWORD.Please apply these changes to fully retire the old env vars and ensure consistency.
🧹 Nitpick comments (1)
docker-compose.yml (1)
7-18: Indentation out of sync with YAML-lint expectations
yamllintflags theimageline (and several others) as over-indented by two spaces. Staying with a strict two-space increment avoids noisy CI warnings.- image: mongo:8.0.12 + image: mongo:8.0.12(The same shift is required for every sibling key under
mongo:.)
No functional change, but it keeps the file CI-clean.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docker-compose.yml(2 hunks)example.env(1 hunks)services/standalone.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- services/standalone.json
- example.env
🧰 Additional context used
🪛 YAMLlint (1.37.1)
docker-compose.yml
[warning] 8-8: wrong indentation: expected 6 but found 4
(indentation)
[warning] 34-34: wrong indentation: expected 6 but found 4
(indentation)
[warning] 37-37: wrong indentation: expected 8 but found 6
(indentation)
[warning] 39-39: wrong indentation: expected 8 but found 6
(indentation)
[warning] 42-42: wrong indentation: expected 8 but found 6
(indentation)
|
petermasking
changed the title
2 participants
Fixes #429
Changes proposed in this pull request:
@MaskingTechnology/comify