Skip to content

[FIX] server_action_mass_edit: add onchange method for selection__ te… #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[FIX] server_action_mass_edit: add onchange method for selection__ te… #1096

wants to merge 1 commit into from
+46 −0

Conversation

adavid-tsc
Copy link

@adavid-tsc adavid-tsc commented Jun 25, 2025 •
edited by StefanRijnhart
Loading

Fixes #1095

File "/home/odoo/src/odoo/addons/web/models/models.py", line 883, in onchange
field = self._fields[field_name]
~~~~~~~~~~~~^^^^^^^^^^^^
KeyError: 'selection__scheduled_date'

When clicking on the action on the model Gear menu we had this
Put back the onchange from 17.0 + edits on line 94

@jjscarafia jjscarafia mentioned this pull request Jun 30, 2025
Merged
@mav-adhoc
Copy link

@adavid-tsc Hi! Can you check the pre-commit error? Thanks!

@adavid-tsc
Copy link
Author

@mav-adhoc I think the PR mentionned up there could resolve this
I didn't test though

@mav-adhoc
Copy link

@adavid-tsc The PR mentioned by jjscarafia? That PR is the one that caused the error in the current module

@Reyes4711-S73
Copy link

LGTM

@mav-adhoc
Copy link

LGTM

@grindtildeath
Copy link

@pedrobaeza @etobella Can you please check this since you didn't want my contribution and proceeded with a separated module?

cc @trisdoan

@legalsylvain
Copy link
Contributor

(Pré commit is failing.)

@twalter-c2c twalter-c2c mentioned this pull request Aug 12, 2025
Open
andreampiovesana
andreampiovesana approved these changes Aug 25, 2025
View reviewed changes
Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcelofrare
marcelofrare approved these changes Aug 25, 2025
View reviewed changes
Copy link

@marcelofrare marcelofrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functional

@mav-adhoc
Copy link

@adavid-tsc Can you check the pre-commit? Thanks!

@andreampiovesana
Copy link

please @adavid-tsc can you fix so we merge?

StefanRijnhart
StefanRijnhart requested changes Sep 24, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you remove the corresponding code from server_action_mass_edit_onchange?

@StefanRijnhart
Copy link
Member

@adavid-tsc I'm addressing my own concerns in adavid-tsc#1, and I also added a test. Please consider merging this one into your branch and then squash the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart requested changes

+3 more reviewers

@andreampiovesana andreampiovesana andreampiovesana approved these changes

@marcelofrare marcelofrare marcelofrare approved these changes

@mav-adhoc mav-adhoc mav-adhoc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue server action mass_edit field name selection_
9 participants
@adavid-tsc @mav-adhoc @Reyes4711-S73 @grindtildeath @legalsylvain @andreampiovesana @StefanRijnhart @marcelofrare @OCA-git-bot