[java] Fix hashCode and equals for additionalProperties and generateAliasAsModel #20831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…penAPITools#20823) * [go-server] Moved helper code from router and updated logger * [go-server] fixed imports for mux and chi * [go-server] fix go-api-server sample test
jpfinne
changed the title
…generateAliasAsModel
…penAPITools#20755) * fix(typescript-nestjs): handle query params serialization properly * fix(typescript-nestjs): updated the samples for param serialization fix
…generateAliasAsModel
6 tasks
This enables use of ResiliencePipelineBuilder which returns the interface when calling AsSyncPolicy / AsAsyncPolicy
* fix operationId mapping * add tests * minor change
* Bump up env_logger to 0.11 * regenerate examples * regenerate examples
Bumps [dorny/test-reporter](https://github.com/dorny/test-reporter) from 1 to 2. - [Release notes](https://github.com/dorny/test-reporter/releases) - [Changelog](https://github.com/dorny/test-reporter/blob/main/CHANGELOG.md) - [Commits](dorny/test-reporter@v1...v2) --- updated-dependencies: - dependency-name: dorny/test-reporter dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#20867) Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.20.13 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-helpers) --- updated-dependencies: - dependency-name: "@babel/helpers" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
martin-mfg
suggested changes
Mar 15, 2025
There was a problem hiding this comment.
Could you also fix hashCode() in this file please?
There was a problem hiding this comment.
Could you add additionalProperties to hashCode() here please?
Comment on lines
34
to
35
| additionalPropertiesOnlyTrue: | ||
| $ref: '#/components/schemas/AdditionalPropertiesOnlyTrue' |
There was a problem hiding this comment.
Please fix the indentation here.
…generateAliasAsModel
…generateAliasAsModel
…alProperties' into fixHashCodeForJavaSingleAdditionalProperties
5 tasks
|
@martin-mfg I ve created a new PR #20902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compilation error for hashcode #20795
Equals also uses additionalProperties if present.
@NilsDammenhayn
The generated code still uses the "new" way of 7.12.0
instead of
This PR only fixes the compilation error for resttemplate, webclient and feign
Microprofile still uses the extends HashMap
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)