-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[java] Fix hashCode and equals for additionalProperties and generateAliasAsModel #20831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jpfinne
wants to merge
48
commits into
OpenAPITools:master
Choose a base branch
from
jpfinne:fixHashCodeForJavaSingleAdditionalProperties
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 15 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
7ca49b4
Fix hashCode for additionalProperties
jpfinne 4ad76cc
[go-server] Moved helper code from router and updated logger for chi …
jarangutan b50b13b
Fix hashcode and equals
jpfinne f0e1a74
Revert Microfile (still using extends HashMap)
jpfinne abf7319
Fix defaultValue for AdditionalProperties fields when using generateA…
jpfinne 349c850
Fix test for defaultValue for AdditionalProperties fields when using …
jpfinne 21be5f5
fix(typescript-nestjs): handle query params serialization properly (#…
mahmoudzeyada 0e34d39
add tests, option for useVirtualHooks (csharp) (#20837)
wing328 3c25de0
Fix test for defaultValue for AdditionalProperties fields when using …
jpfinne d5dcfa6
Remove unused sample
jpfinne 579cd8d
Fix test for AdditionalProperties
jpfinne 01a7e95
Default is still new HashMap<>()
jpfinne b30db6b
Fix missing file in test
jpfinne c5ad4d2
Fix wrong windows path
jpfinne 95b32fd
Files includes FakeApiController
jpfinne b317d38
Files includes FakeApiController
jpfinne 523a992
Remove custom batch
jpfinne 95f2272
Remove .git
jpfinne 8ead4b6
[typescript-angular] fix: correctly serialize query params objects (#…
daniel-sc 7d9e1ec
Bump feign version to 13.5 from 10.12. (#20849)
JoshKeighley20 7f40ce0
Use interfaces for Polly retry policies (#20821)
jacobilsoe e40f9e3
update C# samples
wing328 3ab495a
Fix operationId mapping (#20846)
wing328 5c51ee4
[Rust Server] Bump up env_logger to 0.11 (#20865)
pgoodjohn a3fb8f5
Bump dorny/test-reporter from 1 to 2 (#20862)
dependabot[bot] 1c13655
Bump @babel/helpers from 7.20.13 to 7.26.10 in /website (#20867)
dependabot[bot] b1f572e
[go-server] move errMsg helpers to helpers file (#20876)
jarangutan 89f2fac
fix indentation
jpfinne a5ff8a0
Add handling of hashCode for additionalProperties
jpfinne 984a6f9
Fix hashCode for additionalProperties
jpfinne e9e3411
Fix hashcode and equals
jpfinne 6f2b450
Revert Microfile (still using extends HashMap)
jpfinne 6e3b594
Fix defaultValue for AdditionalProperties fields when using generateA…
jpfinne eb650e0
Fix test for defaultValue for AdditionalProperties fields when using …
jpfinne fc023fe
Fix test for defaultValue for AdditionalProperties fields when using …
jpfinne e6abba4
Remove unused sample
jpfinne cd542a5
Fix test for AdditionalProperties
jpfinne 8ee8978
Default is still new HashMap<>()
jpfinne 44e1999
Fix missing file in test
jpfinne 41e27a8
Fix wrong windows path
jpfinne 5fcb5ab
Files includes FakeApiController
jpfinne bc3ad42
Files includes FakeApiController
jpfinne 05d8e52
Remove custom batch
jpfinne 47cd457
Remove .git
jpfinne f6e9245
fix indentation
jpfinne 4c660ac
Add handling of hashCode for additionalProperties
jpfinne c36f864
fix hashCode for okhttp-gson
jpfinne 1c9d50e
Merge remote-tracking branch 'origin/fixHashCodeForJavaSingleAddition…
jpfinne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
generatorName: java | ||
outputDir: samples/client/petstore/java/resttemplate-generateAliasAsModel | ||
library: resttemplate | ||
inputSpec: modules/openapi-generator/src/test/resources/3_0/java/generateAliasAsModel.yaml | ||
templateDir: modules/openapi-generator/src/main/resources/Java | ||
generateAliasAsModel: true | ||
additionalProperties: | ||
java8: true | ||
useJakartaEe: true | ||
artifactId: petstore-resttemplate-generateAliasAsModel | ||
hideGenerationTimestamp: "true" | ||
generateConstructorWithAllArgs: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
generatorName: spring | ||
outputDir: samples/server/petstore/springboot-generateAliasAsModel | ||
library: spring-boot | ||
inputSpec: modules/openapi-generator/src/test/resources/3_0/java/generateAliasAsModel.yaml | ||
templateDir: modules/openapi-generator/src/main/resources/JavaSpring | ||
generateAliasAsModel: "true" | ||
additionalProperties: | ||
documentationProvider: springfox | ||
useSwaggerUI: false | ||
java8: true | ||
artifactId: spring-boot-generateAliasAsModel | ||
hideGenerationTimestamp: "true" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also fix
hashCode()
in this file please?