-
Notifications
You must be signed in to change notification settings - Fork 2
Retry logic #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry logic #135
Conversation
doc doc
remove import remove wrapped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice API, will be useful for multi-provider support (see #6 ).
Left comments mostly related to refactors and nits 👍
Co-authored-by: Nenad <nenad.misic@openzeppelin.com>
Co-authored-by: Leo <leonard.paturel@openzeppelin.com>
Not immediately obvious. I think if we want to support different retry mechanisms we can do that later. |
0xNeshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work. As discussed, we'll hold of on merging until #140 is ready to be merged, too, so they can be released together.
Co-authored-by: Nenad <nenad.misic@openzeppelin.com>
0xNeshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 🚀 Let's wait for the next release before merging
Resolves #112
Towards #66