Skip to content

Conversation

@LeoPatOZ
Copy link
Collaborator

@LeoPatOZ LeoPatOZ commented Oct 20, 2025

Resolves #112
Towards #66

  1. Do we want to use any other features of backoff here?
  2. Is this sufficient logging?

@LeoPatOZ LeoPatOZ marked this pull request as ready for review October 21, 2025 14:14
@LeoPatOZ LeoPatOZ requested a review from pepebndc as a code owner October 21, 2025 14:14
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice API, will be useful for multi-provider support (see #6 ).
Left comments mostly related to refactors and nits 👍

@0xNeshi 0xNeshi mentioned this pull request Oct 28, 2025
@0xNeshi
Copy link
Collaborator

0xNeshi commented Oct 28, 2025

  1. Do we want to use any other features of backoff here?

Do you think any other features would be useful?

  1. Is this sufficient logging?

For now any logging is great. We'll review as part of #52

@LeoPatOZ
Copy link
Collaborator Author

  1. Do we want to use any other features of backoff here?

Do you think any other features would be useful?

Not immediately obvious. I think if we want to support different retry mechanisms we can do that later.

@0xNeshi 0xNeshi mentioned this pull request Oct 28, 2025
3 tasks
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. As discussed, we'll hold of on merging until #140 is ready to be merged, too, so they can be released together.

Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🚀 Let's wait for the next release before merging

@0xNeshi 0xNeshi merged commit a5affb3 into main Oct 30, 2025
13 checks passed
@0xNeshi 0xNeshi deleted the retry-logic branch October 30, 2025 09:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: External RPC Calls Should be Wrapped in Retry + Backoff Mechanisms

3 participants