-
Notifications
You must be signed in to change notification settings - Fork 1
Stim codegen with annotation #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…g/bloqade-circuit into khwu/stim_annotate
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
david-pl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just wondering whether you'd want to be able to deal with inputs as well.
|
I'm not sure if this should be part of this PR, but f-strings do not work debug.info(f"debug measure {i}") |
weinbe58
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than @david-pl comment this looks good to me.
yeah you would typically write this like: debug.info(f"debug measure", i)which means you would need to implement the additional |
f-string does not support by kirin at the moment. I don't think it should be mixed in this PR. maybe create an issue for "feature" request |
This PR address Status #522