Bump 2.2.0 #81
Bump 2.2.0 #81
Conversation
Signed-off-by: Pyo <pyo@robotis.com>
Updated the CHANGELOG and version to release binary packages
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @robotpilot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request bumps the version of several packages related to the TurtleBot3 manipulation project to 2.2.0. The changes include updating the changelogs to reflect the new version number and a date of April 1, 2025. Additionally, the README.md file has been updated to reflect the current state of the project, including links to documentation, videos, and community resources. Some ament_environment_hooks calls have been removed from CMakeLists.txt files, along with associated env-hook files.
Highlights
- Version Bump: The primary purpose of this PR is to bump the version of multiple packages to 2.2.0.
- Changelog Updates: Changelog files across several packages have been updated to reflect the new version number and a consistent date.
- README.md Update: The README.md file has been significantly updated with new links, improved formatting, and a focus on documentation, videos, and community resources.
- CMakeLists.txt Modifications: The
ament_environment_hookscalls have been removed from some CMakeLists.txt files. - Package Metadata Update: The
package.xmlfile forturtlebot3_manipulation_moveit_confighas been updated to use Apache 2.0 license, new website, repository and bugtracker URLs.
Changelog
Click here to see the changelog
- README.md
- Updated the project title and logo.
- Updated active branches information.
- Reorganized the open-source projects list.
- Added documentation, videos, and community resources sections with relevant links.
- turtlebot3_manipulation/CHANGELOG.rst
- Bumped version to 2.2.0 and updated the date to 2025-04-01.
- Minor text change from 'Support ROS2 Humble' to 'Support ROS 2 Humble'.
- turtlebot3_manipulation_bringup/CHANGELOG.rst
- Bumped version to 2.2.0 and updated the date to 2025-04-01.
- Minor text change from 'Support ROS2 Humble' to 'Support ROS 2 Humble'.
- turtlebot3_manipulation_bringup/CMakeLists.txt
- Removed call to
ament_environment_hooks.
- Removed call to
- turtlebot3_manipulation_bringup/env-hooks/turtlebot3_manipulation_bringup.dsv.in
- Removed the env-hook file.
- turtlebot3_manipulation_cartographer/CHANGELOG.rst
- Bumped version to 2.2.0 and updated the date to 2025-04-01.
- Minor text change from 'Support ROS2 Humble' to 'Support ROS 2 Humble'.
- turtlebot3_manipulation_description/CHANGELOG.rst
- Bumped version to 2.2.0 and updated the date to 2025-04-01.
- Minor text change from 'Support ROS2 Humble' to 'Support ROS 2 Humble'.
- turtlebot3_manipulation_description/CMakeLists.txt
- Removed call to
ament_environment_hooks.
- Removed call to
- turtlebot3_manipulation_description/env-hooks/turtlebot3_manipulation_description.dsv.in
- Removed the env-hook file.
- turtlebot3_manipulation_hardware/CHANGELOG.rst
- Bumped version to 2.2.0 and updated the date to 2025-04-01.
- Minor text change from 'Support ROS2 Humble' to 'Support ROS 2 Humble'.
- turtlebot3_manipulation_moveit_config/CHANGELOG.rst
- Bumped version to 2.2.0 and updated the date to 2025-04-01.
- turtlebot3_manipulation_moveit_config/CMakeLists.txt
- The minimum required CMake version was downgraded from 3.10.2 to 3.5.
- Added comments to the CMakeLists.txt file to improve readability.
- Reordered the CMakeLists.txt file to group related commands together.
- The
ament_package()call was moved to the end of the file.
- turtlebot3_manipulation_moveit_config/package.xml
- Changed the license from BSD to Apache 2.0.
- Updated the website URL to the official documentation.
- Updated the repository and bugtracker URLs to the ROBOTIS-GIT repository.
- Removed comment about gazebo simulation dependencies.
- turtlebot3_manipulation_navigation2/CHANGELOG.rst
- Bumped version to 2.2.0 and updated the date to 2025-04-01.
- Minor text change from 'Support ROS2 Humble' to 'Support ROS 2 Humble'.
- turtlebot3_manipulation_teleop/CHANGELOG.rst
- Bumped version to 2.2.0 and updated the date to 2025-04-01.
- Minor text change from 'Support ROS2 Humble' to 'Support ROS 2 Humble'.
- turtlebot3_manipulation_teleop/CMakeLists.txt
- Added comments to the CMakeLists.txt file to improve readability.
- Reordered the CMakeLists.txt file to group related commands together.
- Removed conditional block for testing dependencies.
- turtlebot3_manipulation_teleop/package.xml
- Removed test dependencies.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A version ascends,
Bumping up, the code mends,
New features alight.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request bumps the version to 2.2.0 and includes updates to the changelogs, CMakeLists.txt, package.xml, env-hooks, and README.md. The changes generally seem to be related to updating dependencies, fixing issues, and improving documentation.
Summary of Findings
- Inconsistent ROS version support notation: The changelogs use both 'Support ROS2 Humble' and 'Support ROS 2 Humble'. It should be consistent.
- Missing documentation for new features: The changelogs mention new features like gripper control in teleoperation, but there's no corresponding documentation update in the README or other relevant files.
- Inconsistent use of absolute vs. relative paths: In the README.md, some image URLs use absolute paths while others use relative paths. It's better to use consistent approach.
- Redundant exec_depend in package.xml: The package.xml file for turtlebot3_manipulation_moveit_config has redundant exec_depend entries.
- Removal of ament_environment_hooks: The removal of
ament_environment_hooksinCMakeLists.txtand the corresponding.dsv.infiles might affect the environment setup. Ensure this change is intentional and doesn't break any functionality.
Merge Readiness
The pull request includes several updates and fixes. However, the inconsistencies in ROS version support notation, missing documentation for new features, and the removal of ament_environment_hooks need to be addressed before merging. I am unable to approve this pull request, and users should have others review and approve this code before merging. Given the medium and high severity issues, I recommend that the pull request not be merged until those are addressed (at a minimum).
| ) | ||
|
|
||
| ament_environment_hooks("${CMAKE_CURRENT_SOURCE_DIR}/env-hooks/${PROJECT_NAME}.dsv.in") | ||
| ################################################################################ |
There was a problem hiding this comment.
The ament_environment_hooks line has been removed. Verify that this is intentional and that the environment is still being set up correctly. This line was responsible for prepending the Gazebo model path, so its removal could affect Gazebo's ability to find the necessary models.
| ) | ||
|
|
||
| ament_environment_hooks("${CMAKE_CURRENT_SOURCE_DIR}/env-hooks/${PROJECT_NAME}.dsv.in") | ||
| ################################################################################ |
There was a problem hiding this comment.
The ament_environment_hooks line has been removed. Verify that this is intentional and that the environment is still being set up correctly. This line was responsible for prepending the Gazebo model path, so its removal could affect Gazebo's ability to find the necessary models.
No description provided.