Skip to content

Conversation

@PrasanthBabuMantena
Copy link

J7200 and J784S4 supports two low poer modes, SOC_OFF and IO_ONLY_PLUS_DDR. Add related documentation for the modes supported and their usage details.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

New warnings found with rstcheck:

source/linux/Foundational_Components/Power_Management/pm_low_power_modes_socoff.rst:59: (WARNING/2) Title overline too short.
source/linux/Foundational_Components/Power_Management/pm_low_power_modes_socoff.rst:59: (WARNING/2) Title overline too short.

@uditkumarti
Copy link
Collaborator

New warnings found with rstcheck:

source/linux/Foundational_Components/Power_Management/pm_low_power_modes_socoff.rst:59: (WARNING/2) Title overline too short.
source/linux/Foundational_Components/Power_Management/pm_low_power_modes_socoff.rst:59: (WARNING/2) Title overline too short.

@PrasanthBabuMantena Please take care of bot warnings

Copy link
Member

@cshilwant cshilwant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are few warnings reported by vale which needs to be addressed
checkout https://github.com/TexasInstruments/processor-sdk-doc/pull/566/files

Copy link
Collaborator

@uditkumarti uditkumarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$subject should start with feat or something,
Please do git log to see format

@github-actions
Copy link

New warnings found with rstcheck:

source/linux/Foundational_Components_Multimedia_wave5.rst:740: (INFO/1) Duplicate implicit target name: "example commands".
source/linux/Foundational_Components_Multimedia_wave5.rst:823: (ERROR/3) Error in "code-block" directive:
source/linux/Foundational_Components_Multimedia_wave5.rst:835: (ERROR/3) Error in "code-block" directive:

@StaticRocket
Copy link
Member

Also some vale warnings about passive voice

StaticRocket
StaticRocket previously approved these changes Dec 13, 2025
@StaticRocket
Copy link
Member

@StaticRocket @cshilwant , only one vale error is that it asks to expand DDR to Double data* in the first reference. Is it required really ?

Nah, I've been fairly lax on acronyms unless they are domain specific. It's the passive voice and simplified language I'm more concerned about. There are still warnings about passive voice.

@StaticRocket StaticRocket self-requested a review December 13, 2025 00:48
Copy link
Contributor

@kwillis01 kwillis01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be good to add a comparison table of SoC off and I/O Only + DDR LPMs so that customers can easily see the differences. Table could include which has better power consumption, resume latency, how it resumes, etc.

@PrasanthBabuMantena
Copy link
Author

@StaticRocket All the passive to active voice conversions have been made and I dont see any warning on that pov now on vale.

@PrasanthBabuMantena
Copy link
Author

Please approve this PR if you don't have any further comments.

Copy link
Collaborator

@uditkumarti uditkumarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks ok. Please address vale warning

uditkumarti
uditkumarti previously approved these changes Dec 15, 2025
gehariprasath
gehariprasath previously approved these changes Dec 15, 2025
Copy link
Collaborator

@gehariprasath gehariprasath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments

cshilwant
cshilwant previously approved these changes Dec 15, 2025
…J784S4

J7200 and J784S4 supports two low poer modes, SOC_OFF and IO_ONLY_PLUS_DDR.
Add related documentation for the modes supported and their usage details.

Signed-off-by: Prasanth Babu Mantena <p-mantena@ti.com>
@gehariprasath gehariprasath merged commit d97872a into TexasInstruments:master Dec 16, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.