Skip to content

Update to 3.13, drop 3.10 #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2024
Merged

Update to 3.13, drop 3.10 #458

merged 2 commits into from
Oct 8, 2024

Conversation

samcunliffe
Copy link
Member

No description provided.

@samcunliffe
Copy link
Member Author

samcunliffe commented Oct 8, 2024 •
edited
Loading

Think we may have to wait for
actions/python-versions#312

(cc. @Saransh-cpp)

@paddyroddy paddyroddy self-requested a review October 8, 2024 14:00
paddyroddy
paddyroddy previously requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look at tutorial.md where it mentions 3.12? We should either remove that (my vote) or update to 3.13.

@dstansby dstansby mentioned this pull request Oct 8, 2024
Merged
dstansby added a commit that referenced this pull request Oct 8, 2024
@dstansby
Remove mention of specific Python version (#459)
8fe8b89 
As proposed by @paddyroddy in
#458 (review),
I think this is a good idea too 👍
@samcunliffe
Copy link
Member Author

Can you look at tutorial.md where it mentions 3.12? We should either remove that (my vote) or update to 3.13.

Reached by @dstansby in #459 🚀

@samcunliffe samcunliffe requested a review from paddyroddy October 8, 2024 16:46
@samcunliffe
Copy link
Member Author

Not related to this PR, but for the repo main ruleset, should we require 3.13 to pass also?

@samcunliffe samcunliffe requested a review from a team October 8, 2024 16:47
@samcunliffe samcunliffe enabled auto-merge (squash) October 8, 2024 16:47
@dstansby dstansby dismissed paddyroddy’s stale review October 8, 2024 17:50

Addressed in another PR

@samcunliffe samcunliffe merged commit 0b32c99 into main Oct 8, 2024
12 checks passed
@samcunliffe samcunliffe deleted the update-python-to-313-drop-310 branch October 8, 2024 17:50
@paddyroddy
Copy link
Member

Not related to this PR, but for the repo main ruleset, should we require 3.13 to pass also?

Yes, I had it ticked on, but then it was blocking #459. Will turn on now, if not already on. I had turned off the 3.10 ones.

@paddyroddy paddyroddy mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

@paddyroddy paddyroddy Awaiting requested review from paddyroddy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samcunliffe @paddyroddy @dstansby