Skip to content

Two reviewers for "opinionated" changes. #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 6, 2024
Merged

Two reviewers for "opinionated" changes. #473

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8d6bc33
Compromise resolution to #350.
samcunliffe Oct 22, 2024
0d3a50c
Merge branch 'main' into 350-move-to-having-two-reviewers-for-pull-re…
paddyroddy Nov 1, 2024
ba92e37
Controversial → opinion(ated)
samcunliffe Nov 4, 2024
6ccb492
Consistently "opinionated"
samcunliffe Nov 4, 2024
78b1d47
Merge branch 'main' into 350-move-to-having-two-reviewers-for-pull-re…
samcunliffe Nov 4, 2024
222faf0
Add two reviewers to the workflow.
samcunliffe Nov 4, 2024
0e8dbc3
Merge branch 'main' into 350-move-to-having-two-reviewers-for-pull-re…
samcunliffe Nov 5, 2024
03abef4
Merge branch 'main' into 350-move-to-having-two-reviewers-for-pull-re…
samcunliffe Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,16 @@ We are actively encouraging users to ask questions and start discussions in the
[discussions tab] of this repository. Does something seem like it's broken?
Please go ahead and [open an issue]!

The [website] pages are open to contributions but they will need to be reviewed
by a member or associate member of ARC. We might be slow to approve new tool
suggestions (since we'll probably want to discuss them first) but don't let that
put you off creating an issue.
The template and [website] pages are open to contributions! But they will need
to be reviewed by a member or associate member of ARC.

We will probably be slow to approve new tool suggestions (since we'll probably
want to discuss them first) but don't let that put you off creating an issue!

Any controversial changes should be approved by at least two reviewers who are
members or associate members of ARC. Pull-request authors are trusted to add two
reviewers to anything that they think might be controversial. If a reviewer adds
a second reviewer, please wait for both to approve before merging.

## Development workflow

Expand Down