[NFC] Remove TODO about Emscripten using --symbolmap #7896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Sep 11, 2025
| // Also register it as "symbolmap" so that wasm-opt --symbolmap=foo is the | ||
| // same as wasm-as --symbolmap=foo even though the latter is not a pass | ||
| // (wasm-as cannot run arbitrary passes). | ||
| // TODO: switch emscripten to this name, then remove the old one |
There was a problem hiding this comment.
How about // TODO: switch existing users (workspace) to this name, then remove the old one
There was a problem hiding this comment.
i.e. we still want to remove the "two names for the same thing"
There was a problem hiding this comment.
I think the two names make sense, actually? One is the usual name we give a pass, and another is a nicer alias. And given this feature is used, I'd rather not break anyone, keeping an alias just for that reason seems reasonable.
sbc100
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.