Fix timing issues on FMCOMMS2 and AD9081/VCU118 #1909
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,25 @@ | ||
| ############################################################################### | ||
| ## Copyright (C) 2014-2023, 2025 Analog Devices, Inc. All rights reserved. | ||
| ### SPDX short identifier: ADIBSD | ||
| ############################################################################### | ||
|
|
||
| source ../../../scripts/adi_env.tcl | ||
| source $ad_hdl_dir/projects/scripts/adi_project_xilinx.tcl | ||
| source $ad_hdl_dir/projects/scripts/adi_board.tcl | ||
| set ADI_POST_ROUTE_SCRIPT [file normalize $ad_hdl_dir/scripts/auto_timing_fix.tcl] | ||
| set BOARD_NAME zc702 | ||
|
|
||
| adi_project fmcomms2_${BOARD_NAME} | ||
| adi_project_files fmcomms2_${BOARD_NAME} [list \ | ||
| "system_top.v" \ | ||
| "system_constr.xdc" \ | ||
| "$ad_hdl_dir/library/common/ad_iobuf.v" \ | ||
| "$ad_hdl_dir/projects/common/${BOARD_NAME}/${BOARD_NAME}_system_constr.xdc" ] | ||
|
|
||
| ## fmcomms2 design is presenting hold time violations on some paths | ||
| ## set the strategy to spread logic and help with hold time fixes | ||
| set_property strategy Congestion_SpreadLogic_high [get_runs impl_1] | ||
|
|
||
| adi_project_run fmcomms2_${BOARD_NAME} | ||
| source $ad_hdl_dir/library/axi_ad9361/axi_ad9361_delay.tcl | ||
|
|
phlfm marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,25 @@ | ||
| ############################################################################### | ||
| ## Copyright (C) 2014-2023, 2025 Analog Devices, Inc. All rights reserved. | ||
| ### SPDX short identifier: ADIBSD | ||
| ############################################################################### | ||
|
|
||
| source ../../../scripts/adi_env.tcl | ||
| source $ad_hdl_dir/projects/scripts/adi_project_xilinx.tcl | ||
| source $ad_hdl_dir/projects/scripts/adi_board.tcl | ||
| set ADI_POST_ROUTE_SCRIPT [file normalize $ad_hdl_dir/scripts/auto_timing_fix.tcl] | ||
| set BOARD_NAME zc706 | ||
|
|
||
| adi_project fmcomms2_${BOARD_NAME} | ||
| adi_project_files fmcomms2_${BOARD_NAME} [list \ | ||
| "system_top.v" \ | ||
| "system_constr.xdc"\ | ||
| "$ad_hdl_dir/library/common/ad_iobuf.v" \ | ||
| "$ad_hdl_dir/projects/common/${BOARD_NAME}/${BOARD_NAME}_system_constr.xdc" ] | ||
|
|
||
| ## fmcomms2 design is presenting hold time violations on some paths | ||
| ## set the strategy to spread logic and help with hold time fixes | ||
| set_property strategy Congestion_SpreadLogic_high [get_runs impl_1] | ||
|
|
||
| adi_project_run fmcomms2_${BOARD_NAME} | ||
| source $ad_hdl_dir/library/axi_ad9361/axi_ad9361_delay.tcl | ||
|
|
phlfm marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,25 @@ | ||
| ############################################################################### | ||
| ## Copyright (C) 2014-2023, 2025 Analog Devices, Inc. All rights reserved. | ||
| ### SPDX short identifier: ADIBSD | ||
| ############################################################################### | ||
|
|
||
| source ../../../scripts/adi_env.tcl | ||
| source $ad_hdl_dir/projects/scripts/adi_project_xilinx.tcl | ||
| source $ad_hdl_dir/projects/scripts/adi_board.tcl | ||
| set ADI_POST_ROUTE_SCRIPT [file normalize $ad_hdl_dir/scripts/auto_timing_fix.tcl] | ||
| set BOARD_NAME zcu102 | ||
|
|
||
| adi_project fmcomms2_${BOARD_NAME} | ||
| adi_project_files fmcomms2_${BOARD_NAME} [list \ | ||
| "system_top.v" \ | ||
| "system_constr.xdc"\ | ||
| "$ad_hdl_dir/library/common/ad_iobuf.v" \ | ||
| "$ad_hdl_dir/projects/common/${BOARD_NAME}/${BOARD_NAME}_system_constr.xdc" ] | ||
|
|
||
| ## fmcomms2 design is presenting hold time violations on some paths | ||
| ## set the strategy to spread logic and help with hold time fixes | ||
| set_property strategy Congestion_SpreadLogic_high [get_runs impl_1] | ||
|
|
||
| adi_project_run fmcomms2_${BOARD_NAME} | ||
| source $ad_hdl_dir/library/axi_ad9361/axi_ad9361_delay.tcl | ||
|
|
phlfm marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,24 @@ | ||
| ############################################################################### | ||
| ## Copyright (C) 2014-2023, 2025 Analog Devices, Inc. All rights reserved. | ||
| ### SPDX short identifier: ADIBSD | ||
| ############################################################################### | ||
|
|
||
| source ../../../scripts/adi_env.tcl | ||
| source $ad_hdl_dir/projects/scripts/adi_project_xilinx.tcl | ||
| source $ad_hdl_dir/projects/scripts/adi_board.tcl | ||
| set ADI_POST_ROUTE_SCRIPT [file normalize $ad_hdl_dir/scripts/auto_timing_fix.tcl] | ||
| set BOARD_NAME zed | ||
|
|
||
| adi_project fmcomms2_${BOARD_NAME} | ||
| adi_project_files fmcomms2_${BOARD_NAME} [list \ | ||
| "system_top.v" \ | ||
| "system_constr.xdc"\ | ||
| "$ad_hdl_dir/library/common/ad_iobuf.v" \ | ||
| "$ad_hdl_dir/projects/common/${BOARD_NAME}/${BOARD_NAME}_system_constr.xdc" ] | ||
|
|
||
| ## fmcomms2 design is presenting hold time violations on some paths | ||
| ## set the strategy to spread logic and help with hold time fixes | ||
| set_property strategy Congestion_SpreadLogic_high [get_runs impl_1] | ||
|
|
||
| adi_project_run fmcomms2_${BOARD_NAME} | ||
| source $ad_hdl_dir/library/axi_ad9361/axi_ad9361_delay.tcl |
|
There was a problem hiding this comment. Typo line 321: existing. Add source files to an existing project. There was a problem hiding this comment. I know it is not related to this commit, but maybe it could be added as well. It is not necessary the elseif in line 332, just an else satisfies the filter for constrs_1 and sources_1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| ############################################################################### | ||
| ## Copyright (C) 2025 Analog Devices, Inc. All rights reserved. | ||
| ### SPDX short identifier: ADIBSD | ||
| ############################################################################### | ||
| # This script attempts to automatically fix timing violations after routing | ||
phlfm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # using phys_opt_design. It will make multiple attempts up to a maximum number | ||
| # of tries, or until no violations remain. It can be configured via the | ||
| # ADI_AUTOFIX_WNS_THRESHOLD and ADI_AUTOFIX_MAX_ATTEMPTS environment variables. | ||
| # | ||
| # ADI_AUTOFIX_WNS_THRESHOLD limits the worst negative slack (WNS) that will be | ||
| # automatically fixed. If the WNS is worse than this threshold, no automatic fix | ||
| # will be attempted. The threshold should be a negative number and the value is | ||
| # in nanoseconds. For example, a threshold of -1.0 means that only violations | ||
| # where "0 > WNS > -1.0 ns" will be automatically fixed. | ||
| # | ||
| puts "INFO: starting auto timing fix (ATF)..." | ||
| set attempt 0 | ||
|
|
||
| # Set default values if not provided | ||
| if {![info exists ADI_AUTOFIX_WNS_THRESHOLD]} { | ||
| set ADI_AUTOFIX_WNS_THRESHOLD -1.0 | ||
| puts "INFO: ATF: ADI_AUTOFIX_WNS_THRESHOLD not set, using default of $ADI_AUTOFIX_WNS_THRESHOLD" | ||
| } | ||
| if {![info exists ADI_AUTOFIX_MAX_ATTEMPTS]} { | ||
| set ADI_AUTOFIX_MAX_ATTEMPTS 5 | ||
| puts "INFO: ATF: ADI_AUTOFIX_MAX_ATTEMPTS not set, using default of $ADI_AUTOFIX_MAX_ATTEMPTS" | ||
| } | ||
|
|
||
| while {$attempt < $ADI_AUTOFIX_MAX_ATTEMPTS} { | ||
| # Get the single worst timing path object in the design | ||
| set worst_path [get_timing_paths -nworst 1 -max_paths 1 -delay_type min_max] | ||
| if {[llength $worst_path] == 0} { break } ; # No paths found | ||
| set wns [get_property SLACK $worst_path] | ||
| if {${wns} >= 0.0} { break } ; # No violations remain | ||
| set delay_type [get_property DELAY_TYPE $worst_path] ;# Returns "max" for Setup, "min" for Hold | ||
| # Check if autofix should attempt based on WNS threshold | ||
| if {$wns > $ADI_AUTOFIX_WNS_THRESHOLD} { | ||
| incr attempt | ||
| puts "INFO: ATF: WNS = ${wns} ns of type $delay_type. Attempting automatic fix (${attempt} of ${ADI_AUTOFIX_MAX_ATTEMPTS})." | ||
| report_timing_summary -delay_type min_max -max_paths 5 -nworst 1 -file "AutoTimingFix_${attempt}_before_timing_summary.txt" | ||
| } else { | ||
| break ; # Abort automatic fix due to WNS threshold | ||
| } | ||
| # Attempt fix via phys_opt_design | ||
| write_checkpoint -force "AutoTimingFix_${attempt}_before_system_top_placed.dcp" | ||
| if {$delay_type eq "min"} { | ||
| phys_opt_design -hold_fix | ||
| } elseif {$delay_type eq "max"} { | ||
| phys_opt_design | ||
| } else { | ||
| puts "ERROR: ATF: Unknown path type '${delay_type}'. Aborting automatic fix." | ||
| break | ||
| } | ||
| } | ||
|
|
||
| write_checkpoint -force "AutoTimingFix_${attempt}_final_system_top_placed.dcp" | ||
| report_timing_summary -delay_type min_max -max_paths 5 -nworst 1 -file "AutoTimingFix_${attempt}_final_timing_summary.txt" | ||
|
|
||
| # Print a final report | ||
| if {[llength $worst_path] == 0} { | ||
| # Loop broke early due to no paths found | ||
| puts "ERROR: ATF: No constrained timing paths found. Exiting." | ||
| } elseif {${attempt} == 0 && ${wns} >= 0.0} { | ||
| # Loop broke early due to no violations on first check | ||
| puts "INFO: ATF: No timing violations detected on first check. No action required." | ||
| } else { | ||
| # Loop broke after at least one attempt | ||
| set worst_path [get_timing_paths -nworst 1 -max_paths 1 -delay_type min_max] | ||
| set final_wns [get_property SLACK $worst_path] | ||
| if {$final_wns >= 0} { | ||
| puts "INFO: ATF: auto timing fix SUCCESS after ${attempt} attempts - final WNS is ${final_wns} ns." | ||
| } elseif {$final_wns <= $ADI_AUTOFIX_WNS_THRESHOLD} { | ||
| puts "WARNING: ATF: WNS (${wns} ns) excedes threshold (${ADI_AUTOFIX_WNS_THRESHOLD} ns). Automatic fix aborted." | ||
|
||
| } else { | ||
| puts "WARNING: ATF: auto timing fix FAILURE after ${attempt} attempts - final WNS is ${final_wns} ns." | ||
| } | ||
| } | ||
|
|
||
| puts "INFO: auto timing fix (ATF) finished." | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.