feat(spark): Implement Spark string function luhn_check
#16848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standing-Man
changed the title
string function luhn_check
Standing-Man
commented
Jul 22, 2025
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Standing-Man
commented
Jul 24, 2025
alamb
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
Thank you @Standing-Man -- this looks good to me
@shehabgamin does this look good to you (at a high level)?
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
Will review when I'm home in the next few hours! |
comphead
approved these changes
Jul 25, 2025
shehabgamin
reviewed
Jul 25, 2025
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
shehabgamin
approved these changes
Jul 25, 2025
Signed-off-by: Alan Tang <jmtangcs@gmail.com>
|
Appreciate the reviews, everyone! |
|
Nice teamwork! Thanks everyone |
|
✋ ✋ |
adriangb
pushed a commit
to pydantic/datafusion
that referenced
this pull request
Jul 28, 2025
…6848) * feat(spark): Implement Spark luhn_check function Signed-off-by: Alan Tang <jmtangcs@gmail.com> * test(spark): add more tests Signed-off-by: Alan Tang <jmtangcs@gmail.com> * feat(spark): set the signature to be Utf8 type Signed-off-by: Alan Tang <jmtangcs@gmail.com> * chore: add more types for luhn_check function Signed-off-by: Alan Tang <jmtangcs@gmail.com> * test: add test for array input Signed-off-by: Alan Tang <jmtangcs@gmail.com> --------- Signed-off-by: Alan Tang <jmtangcs@gmail.com>
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-sparkSpark Compatible Functions #15914.stringfunctionluhn_check#16612 andluhn_checkfunction #16580.Rationale for this change
What changes are included in this PR?
Implement Spark
luhn_checkfunctionAre these changes tested?
Yes
Are there any user-facing changes?
Yes