-
Notifications
You must be signed in to change notification settings - Fork 14.5k
KAFKA-19499: Corrected the logger name in PersisterStateManagerHandler #20175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@chirag-wadhwa5 The build is failing with Persister tests, can you please fix. |
Thanks for the review @apoorvmittal10 . I have pushed the required changes. The new build report has only unrelated failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch, LGTM.
nit: "it will be possible t" -> "it will be possible to"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chirag-wadhwa5: This patch LGTM.
Could you please merge the trunk?
The failed test should have been fixed on the trunk..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, probably do it with some other commit in future, if you think that's right. LGTM!
String canonicalName = getClass().getCanonicalName(); | ||
if (canonicalName == null) { | ||
canonicalName = getClass().getName(); | ||
} | ||
log = LoggerFactory.getLogger(canonicalName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: probaly can do later as well. Becuase now it's not always the canonical name in the variable.
String canonicalName = getClass().getCanonicalName(); | |
if (canonicalName == null) { | |
canonicalName = getClass().getName(); | |
} | |
log = LoggerFactory.getLogger(canonicalName); | |
String name = getClass().getCanonicalName(); | |
if (name == null) { | |
name = getClass().getName(); | |
} | |
log = LoggerFactory.getLogger(name); |
This PR corrects the name of logger in the inner class
PersisterStateManagerHandler. After this change it will be possible to
change the log level dynamically in the kafka brokers. This PR also
includes a small change in a log line in GroupCoordinatorService, making
it clearer.
Reviewers: Apoorv Mittal apoorvmittal10@gmail.com, Sushant Mahajan smahajan@confluent.io, Lan Ding isDing_L@163.com, TengYao Chi frankvicky@apache.org