Skip to content

KAFKA-19499: Corrected the logger name in PersisterStateManagerHandler #20175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2025
Merged

KAFKA-19499: Corrected the logger name in PersisterStateManagerHandler #20175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a898da
Corrected the logger name in PersisterStateManagerHandler
chirag-wadhwa5 Jul 16, 2025
8dab6e0
Resolved test failures in PersisterStateManagerTest
chirag-wadhwa5 Jul 16, 2025
332b442
Merge remote-tracking branch 'upstream/trunk' into KAFKA-19499
chirag-wadhwa5 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ private CompletableFuture<ShareGroupHeartbeatResponseData> handlePersisterInitia
}
return performShareGroupStateMetadataInitialize(groupId, topicPartitionMap, defaultResponse);
}
log.error("Received error while calling initialize state for {} on persister {}.", groupId, persisterError.code());
log.error("Received error while calling initialize state for {} on persister, errorCode: {}.", groupId, persisterError.code());
return uninitializeShareGroupState(persisterError, groupId, topicPartitionMap);
}

Expand Down
7 changes: 6 additions & 1 deletion ...r-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ public void setGenerateCallback(Runnable generateCallback) {
public abstract class PersisterStateManagerHandler implements RequestCompletionHandler {
protected Node coordinatorNode;
private final BackoffManager findCoordBackoff;
protected final Logger log = LoggerFactory.getLogger(getClass());
protected final Logger log;
private Consumer<ClientResponse> onCompleteCallback;
protected final SharePartitionKey partitionKey;

Expand All @@ -237,6 +237,11 @@ public PersisterStateManagerHandler(
this.onCompleteCallback = response -> {
}; // noop
partitionKey = SharePartitionKey.getInstance(groupId, topicId, partition);
String canonicalName = getClass().getCanonicalName();
if (canonicalName == null) {
canonicalName = getClass().getName();
}
log = LoggerFactory.getLogger(canonicalName);
Comment on lines +240 to +244
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: probaly can do later as well. Becuase now it's not always the canonical name in the variable.

Suggested change
String canonicalName = getClass().getCanonicalName();
if (canonicalName == null) {
canonicalName = getClass().getName();
}
log = LoggerFactory.getLogger(canonicalName);
String name = getClass().getCanonicalName();
if (name == null) {
name = getClass().getName();
}
log = LoggerFactory.getLogger(name);

}

/**
Expand Down