[SPARK-54468][SDP] Add missing error classes #53186
Conversation
|
@sryza Have a look and LMK if new tests should be added. Happy to learn how to add them if needed. Please guide 🙏 |
| "message" : [ | ||
| "Invalid destination <tableName> with multiple flows: <flows>." | ||
| ], | ||
| "sqlState" : "42000" |
There was a problem hiding this comment.
Can we provide a more specific SQL state?
There was a problem hiding this comment.
I've got no idea what would make SQL states more specific, and picked 42000 at random. Can you guide me how to make it more specific, @allisonwang-db 🙏
There was a problem hiding this comment.
I did some investigation into this and couldn't figure out a better SQL state than 42000. @allisonwang-db do you have on in mind? If not, mind if we stick with this?
…or-classes-unavailable
…or-classes-unavailable
|
@sryza @dongjoon-hyun Do you have any idea which |
| "message" : [ | ||
| "Invalid destination <tableName> with multiple flows: <flows>." | ||
| ], | ||
| "sqlState" : "42000" |
There was a problem hiding this comment.
I did some investigation into this and couldn't figure out a better SQL state than 42000. @allisonwang-db do you have on in mind? If not, mind if we stick with this?
sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/GraphValidations.scala
Show resolved
Hide resolved
3 participants
What changes were proposed in this pull request?
Added two missing error classes
Why are the changes needed?
MATERIALIZED_VIEW_WITH_MULTIPLE_QUERIESandPIPELINE_GRAPH_NOT_TOPOLOGICALLY_SORTEDerror classes were not defined yet used in SDP.Does this PR introduce any user-facing change?
Sort of. It fixes what should be reported properly with the error classes.
How was this patch tested?
Built locally. Awaiting the official build to pass
Was this patch authored or co-authored using generative AI tooling?
No