Skip to content

[SPARK-54468][SDP] Add missing error classes #53186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaceklaskowski wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[SPARK-54468][SDP] Add missing error classes #53186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a02d46
Add missing error classes
jaceklaskowski Nov 23, 2025
30cabfd
Merge remote-tracking branch 'origin/master' into SPARK-54468-sdp-err…
jaceklaskowski Nov 28, 2025
74fd28f
Merge remote-tracking branch 'origin/master' into SPARK-54468-sdp-err…
jaceklaskowski Dec 1, 2025
f6cd1df
addressing review comments
jaceklaskowski Dec 4, 2025
22c95a2
Merge remote-tracking branch 'origin/master' into SPARK-54468-sdp-err…
jaceklaskowski Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions common/utils/src/main/resources/error/error-conditions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2873,6 +2873,12 @@
},
"sqlState" : "42602"
},
"MATERIALIZED_VIEW_WITH_MULTIPLE_QUERIES" : {
"message" : [
"Invalid destination <tableName> with multiple flows: <flows>."
],
"sqlState" : "42000"
Copy link
Contributor

@allisonwang-db allisonwang-db Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we provide a more specific SQL state?

Copy link
Contributor Author

@jaceklaskowski jaceklaskowski Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got no idea what would make SQL states more specific, and picked 42000 at random. Can you guide me how to make it more specific, @allisonwang-db 🙏

Copy link
Contributor

@sryza sryza Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some investigation into this and couldn't figure out a better SQL state than 42000. @allisonwang-db do you have on in mind? If not, mind if we stick with this?

Copy link
Contributor

@allisonwang-db allisonwang-db Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 42710?

},
"INVALID_DRIVER_MEMORY" : {
"message" : [
"System memory <systemMemory> must be at least <minSystemMemory>.",
Expand Down Expand Up @@ -5069,6 +5075,12 @@
},
"sqlState" : "42710"
},
"PIPELINE_GRAPH_NOT_TOPOLOGICALLY_SORTED" : {
"message" : [
"There is a cycle between <flowName> and <inputName>."
],
"sqlState" : "0A000"
},
"PIPELINE_SQL_GRAPH_ELEMENT_REGISTRATION_ERROR" : {
"message" : [
"<message>",
Expand Down
7 changes: 5 additions & 2 deletions sql/pipelines/src/main/scala/org/apache/spark/sql/pipelines/graph/GraphValidations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,10 @@ trait GraphValidations extends Logging {
"MATERIALIZED_VIEW_WITH_MULTIPLE_QUERIES",
Map(
"tableName" -> dest.unquotedString,
"queries" -> flows.map(_.identifier).mkString(",")
"flows" -> flows
.map(_.displayName)
.sorted
.mkString(", ")
)
)
}
Expand Down Expand Up @@ -150,7 +153,7 @@ trait GraphValidations extends Logging {
throw new AnalysisException(
"PIPELINE_GRAPH_NOT_TOPOLOGICALLY_SORTED",
Map(
"flowName" -> f.identifier.unquotedString,
"flowName" -> f.displayName,
"inputName" -> unvisitedInput.unquotedString
)
)
Expand Down