Uniffi 0.29.1 #34
Uniffi 0.29.1 #34
Conversation
Allow patch updates that might fix bugs. If `=` is used to work around a specific bug, it should be documented in Cargo.toml. If reproducible builds require a specific version, a Cargo.lock would be better suited.
|
ACK 039dbf4 |
|
Thanks for this @DanGould! I'm curious to know what bugs the 0.29.1 fixed for you? For the pin, I'm open to removing it and allowing cargo to auto-update uniffi, but know that the errors might start coming in "the other way" so to speak. Uniffi has unfortunately been not always perfect at following semantic versioning, and have released breaking changes in patch versions in the past (twice that I remember, and is the reason why I prefer it pinned in bdk-ffi). We instead keep an eye on the releases and update manually when they come out. But I understand it also has a useful side, so I'm open to it. 👍 |
|
Specifically I believe it was the bindings not implementing Lift for many types (Bindings support lift and lower for CustomTypes in uniffi.toml to match the docs (mozilla/uniffi-rs#2438)) so I couldn't use bitocin-ffi in payjoin-ffi |
3 participants
0.29.1 contains some bug fixes which appear necessary to embed bitcoin-ffi types in payjoin-ffi. I wasn't able to build on them with proc macros otherwise.
I've also removed the exact
=Cargo.toml dependency version specification since that prevented this bug fix from being applied without this upstream change.