feat: Use fetcher in workflow history #1064
Merged
+86
−254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
macrotim
approved these changes
Nov 5, 2025
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Assem-Uber
deleted the
feature/15952/use-fetcher-in-workflow-history-page
branch
Assem-Uber
added a commit
to Assem-Uber/cadence-web
that referenced
this pull request
Nov 19, 2025
* Create fetcher utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename query Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add configurable throttleMs to the hook Signed-off-by: Assem Hafez <assem.hafez@uber.com> * use fetcher in workflow history * remove useKeepLoadingEvents Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update fetcher based on feedback Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename unmout to destroy Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * move condition into executeImmediately Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update destroy in method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix type error with query params Signed-off-by: Assem Hafez <assem.hafez@uber.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use new fetcher hook in the history page. This replaces old logic of
useKeepLoadingEventshook which depends on the render cycle completion to start fetching the next page. The new hook allows throttle query data updates and render once after few requested pages.Changes
useSuspenseInfiniteQuerywith the new fetcher hookuseKeepLoadingEventswith usage for start/stop methods from fetcheruseKeepLoadingEventsas it is no longer used.Recording
Using custom buttons to validate start/stop/error of the fetcher on the history page.
The start/pause/error buttons are for testing purposes
Tested scenarios:
Screen.Recording.2025-11-03.at.11.07.09.mov
Risks
If fetcher is problematic, loading more pages may not happen. Ending up with a partially fetched history.