Skip to content

Conversation

victormlg
Copy link
Contributor

@victormlg victormlg commented Sep 2, 2025

Merge together:
cfengine/masterfiles#3050

@cf-bottom
Copy link

Thanks for submitting a PR! Maybe @craigcomstock can review this?

@victormlg victormlg marked this pull request as ready for review October 2, 2025 14:37
@victormlg
Copy link
Contributor Author

Build Status

@victormlg victormlg force-pushed the sys_policy_version branch 2 times, most recently from 387dcc6 to decce9b Compare October 2, 2025 15:39
@victormlg victormlg requested a review from larsewi October 2, 2025 15:39
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Ticket: ENT-4043
Changelog: Title
Signed-off-by: Victor Moene <victor.moene@northern.tech>
@victormlg victormlg requested a review from larsewi October 6, 2025 08:20
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because of a mistake in the masterfiles PR.

Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good 🚀

{
EvalContextVariablePutSpecial(ctx, SPECIAL_SCOPE_SYS, "policy_version", version, CF_DATA_TYPE_STRING,
"inventory,source=agent,attribute_name=CFEngine policy version,derived-from=common_control.version");
"inventory,source=agent,attribute_name=CFEngine policy version,derived-from=default:control_common.version");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change belongs in the previous commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants