ENT-4043: Disabled policy versions #3050
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickanderson
approved these changes
Oct 2, 2025
inventory/any.cf
Outdated
| disable_mpf_policy_version:: | ||
| "policy_version" -> { "ENT-9806" } | ||
| string => "$(default:control_common.version)", | ||
| meta => { "inventory", "attribute_name=CFEngine policy version" }; |
There was a problem hiding this comment.
I removed the class definition above because we aren't using that class to constrain more than a single promise and additionally it didn't seem useful for me to allow users to define the disable_mpf_policy_version class to affect this behavior.
Try this (untested)
Suggested change
| meta => { "inventory", "attribute_name=CFEngine policy version" }; | |
| "policy_version" -> { "ENT-9806" } | |
| string => "$(default:control_common.version)", | |
| meta => { "inventory", "attribute_name=CFEngine policy version" } | |
| if => isvariable("$(sys.policy_version)"), | |
| comment => concat( "Don't inventory the policy version from policy when it's available", | |
| " as a sys var to avoid duplicate values being inventoried."); |
There was a problem hiding this comment.
Shouldn't it be
if => not(isvariable("sys.policy_version")),
Since we want to define this variable only if sys.policy_version doesn't already exist?
victormlg
force-pushed
the
sys_policy_version
branch
from
cb94248 to
47ccda7
Compare
olehermanse
reviewed
Oct 6, 2025
olehermanse
requested changes
Oct 6, 2025
victormlg
force-pushed
the
sys_policy_version
branch
from
47ccda7 to
15e2ac3
Compare
olehermanse
reviewed
Oct 6, 2025
Changelog: Disabled policy version in masterfiles because it is now managed and inventoried by default by the core agent inside sys.policy_version. Ticket: ENT-4043 Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
sys_policy_version
branch
from
15e2ac3 to
b42530a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge together:
cfengine/core#5873