Skip to content

⚡️ Speed up method RadialLocator._zero_in_bounds by 59% #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method RadialLocator._zero_in_bounds by 59% #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/matplotlib/projections/polar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ class RadialLocator(mticker.Locator):
def __init__(self, base, axes=None):
self.base = base
self._axes = axes
self._zero_in_bounds_cache = None

def set_axis(self, axis):
self.base.set_axis(axis)
Expand All @@ -498,8 +499,14 @@ def _zero_in_bounds(self):
Return True if zero is within the valid values for the
scale of the radial axis.
"""
if self._zero_in_bounds_cache is not None:
cached_axes, cached_result = self._zero_in_bounds_cache
if cached_axes is self._axes:
return cached_result
vmin, vmax = self._axes.yaxis._scale.limit_range_for_scale(0, 1, 1e-5)
return vmin == 0
result = vmin == 0
self._zero_in_bounds_cache = (self._axes, result)
return result

def nonsingular(self, vmin, vmax):
# docstring inherited
Expand Down