cmd-osbuild: add comment for relevance of rootful codepath #4260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up in the prior code review [1] and we agreed to add the comment as a followon PR. [1] coreos#4251 (comment)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a comment to explain the rationale for the rootful codepath in cmd-osbuild, particularly its relevance for the riscv architecture. The change is straightforward and adds valuable context for future maintainers. I have one minor suggestion to improve the clarity of the new comment.
| cmd="env" # run outside of supermin if we are root already | ||
| # Run outside of supermin if we are root already. This is useful | ||
| # mostly on riscv where /dev/kvm isn't really supported by any | ||
| # hardware right now (2025/08). |
Contributor
There was a problem hiding this comment.
The phrase "right now" is a bit redundant given that a specific date is provided in parentheses. For conciseness and clarity, you could remove "right now".
# hardware (2025/08).
jlebon
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in the prior code review [1] and we agreed to add the comment as a followon PR.
[1] #4251 (comment)