Skip to content

Conversation

@PlaidCat
Copy link
Collaborator

@PlaidCat PlaidCat commented Oct 9, 2025

Just a test do not merge

jira VULN-67698
jira VULN-67697
cve CVE-2025-37797
commit-author Cong Wang <xiyou.wangcong@gmail.com>
commit 3df275e

This patch fixes a Use-After-Free vulnerability in the HFSC qdisc class
handling. The issue occurs due to a time-of-check/time-of-use condition
in hfsc_change_class() when working with certain child qdiscs like netem
or codel.

The vulnerability works as follows:
1. hfsc_change_class() checks if a class has packets (q.qlen != 0)
2. It then calls qdisc_peek_len(), which for certain qdiscs (e.g.,
   codel, netem) might drop packets and empty the queue
3. The code continues assuming the queue is still non-empty, adding
   the class to vttree
4. This breaks HFSC scheduler assumptions that only non-empty classes
   are in vttree
5. Later, when the class is destroyed, this can lead to a Use-After-Free

The fix adds a second queue length check after qdisc_peek_len() to verify
the queue wasn't emptied.

Fixes: 21f4d5c ("net_sched/hfsc: fix curve activation in hfsc_change_class()")
	Reported-by: Gerrard Tai <gerrard.tai@starlabs.sg>
	Reviewed-by: Konstantin Khlebnikov <koct9i@gmail.com>
	Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
	Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Link: https://patch.msgid.link/20250417184732.943057-2-xiyou.wangcong@gmail.com
	Signed-off-by: Jakub Kicinski <kuba@kernel.org>
(cherry picked from commit 3df275e)
	Signed-off-by: Jonathan Maple <jmaple@ciq.com>
jira VULN-136339
jira VULN-136338
cve CVE-2025-38718
commit-author Xin Long <lucien.xin@gmail.com>
commit fd60d8a

A cloned head skb still shares these frag skbs in fraglist with the
original head skb. It's not safe to access these frag skbs.

syzbot reported two use-of-uninitialized-memory bugs caused by this:

  BUG: KMSAN: uninit-value in sctp_inq_pop+0x15b7/0x1920 net/sctp/inqueue.c:211
   sctp_inq_pop+0x15b7/0x1920 net/sctp/inqueue.c:211
   sctp_assoc_bh_rcv+0x1a7/0xc50 net/sctp/associola.c:998
   sctp_inq_push+0x2ef/0x380 net/sctp/inqueue.c:88
   sctp_backlog_rcv+0x397/0xdb0 net/sctp/input.c:331
   sk_backlog_rcv+0x13b/0x420 include/net/sock.h:1122
   __release_sock+0x1da/0x330 net/core/sock.c:3106
   release_sock+0x6b/0x250 net/core/sock.c:3660
   sctp_wait_for_connect+0x487/0x820 net/sctp/socket.c:9360
   sctp_sendmsg_to_asoc+0x1ec1/0x1f00 net/sctp/socket.c:1885
   sctp_sendmsg+0x32b9/0x4a80 net/sctp/socket.c:2031
   inet_sendmsg+0x25a/0x280 net/ipv4/af_inet.c:851
   sock_sendmsg_nosec net/socket.c:718 [inline]

and

  BUG: KMSAN: uninit-value in sctp_assoc_bh_rcv+0x34e/0xbc0 net/sctp/associola.c:987
   sctp_assoc_bh_rcv+0x34e/0xbc0 net/sctp/associola.c:987
   sctp_inq_push+0x2a3/0x350 net/sctp/inqueue.c:88
   sctp_backlog_rcv+0x3c7/0xda0 net/sctp/input.c:331
   sk_backlog_rcv+0x142/0x420 include/net/sock.h:1148
   __release_sock+0x1d3/0x330 net/core/sock.c:3213
   release_sock+0x6b/0x270 net/core/sock.c:3767
   sctp_wait_for_connect+0x458/0x820 net/sctp/socket.c:9367
   sctp_sendmsg_to_asoc+0x223a/0x2260 net/sctp/socket.c:1886
   sctp_sendmsg+0x3910/0x49f0 net/sctp/socket.c:2032
   inet_sendmsg+0x269/0x2a0 net/ipv4/af_inet.c:851
   sock_sendmsg_nosec net/socket.c:712 [inline]

This patch fixes it by linearizing cloned gso packets in sctp_rcv().

Fixes: 90017ac ("sctp: Add GSO support")
	Reported-by: syzbot+773e51afe420baaf0e2b@syzkaller.appspotmail.com
	Reported-by: syzbot+70a42f45e76bede082be@syzkaller.appspotmail.com
	Signed-off-by: Xin Long <lucien.xin@gmail.com>
	Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Link: https://patch.msgid.link/dd7dc337b99876d4132d0961f776913719f7d225.1754595611.git.lucien.xin@gmail.com
	Signed-off-by: Jakub Kicinski <kuba@kernel.org>
(cherry picked from commit fd60d8a)
	Signed-off-by: Jonathan Maple <jmaple@ciq.com>
@PlaidCat PlaidCat self-assigned this Oct 9, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR contains VULN tickets that do not match the target LTS product. Please review the JIRA ticket assignments and ensure they match the merge target branch.

@PlaidCat PlaidCat force-pushed the {jmaple}_fips-8-compliant/4.18.0-553.16.1 branch from 22dabbc to 4edda16 Compare October 9, 2025 12:24
@ctrliq ctrliq deleted a comment from github-actions bot Oct 9, 2025
@PlaidCat PlaidCat force-pushed the {jmaple}_fips-8-compliant/4.18.0-553.16.1 branch from 4edda16 to b65c1c6 Compare October 9, 2025 12:56
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

JIRA PR Check Results

3 commit(s) with issues found:

Commit 353ee378d3ef

Summary: NFS: Fix filehandle bounds checking in nfs_fh_to_dentry()

❌ Errors:

  • VULN-136573: Status is 'To Do', expected 'In Progress'
  • VULN-136573: LTS product 'lts-8.6' expects branch 'ciqlts8_6', but merge target is 'fips-8-compliant/4.18.0-553.16.1'

⚠️ Warnings:

  • VULN-136573: No time logged - please log time manually

Commit f631fe5b7fff

Summary: sctp: linearize cloned gso packets in sctp_rcv

❌ Errors:

  • VULN-136339: Status is 'To Do', expected 'In Progress'

Commit 104675413a08

Summary: net_sched: hfsc: Fix a UAF vulnerability in class handling

⚠️ Warnings:

  • VULN-67697: No time logged - please log time manually

Summary: Checked 4 commit(s) total.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR contains VULN tickets that do not match the target LTS product. Please review the JIRA ticket assignments and ensure they match the merge target branch.

jira VULN-136575
jira VULN-136574
jira VULN-136573
cve CVE-2025-39730
cve CVE-2025-1234556789
cve-bf CVE-2025-39730
commit-author Trond Myklebust <trond.myklebust@hammerspace.com>
commit ef93a68

The function needs to check the minimal filehandle length before it can
access the embedded filehandle.

	Reported-by: zhangjian <zhangjian496@huawei.com>
Fixes: 20fa190 ("nfs: add export operations")
	Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
(cherry picked from commit ef93a68)
	Signed-off-by: Jonathan Maple <jmaple@ciq.com>
@PlaidCat PlaidCat force-pushed the {jmaple}_fips-8-compliant/4.18.0-553.16.1 branch from b65c1c6 to 3499125 Compare October 9, 2025 15:53
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

JIRA PR Check Results

3 commit(s) with issues found:

Commit 2621a890be52

Summary: NFS: Fix filehandle bounds checking in nfs_fh_to_dentry()

❌ Errors:

  • VULN-136575: CVE mismatch - Commit has CVE-2025-1234556789 but VULN ticket does not
  • VULN-136574: CVE mismatch - Commit has CVE-2025-1234556789 but VULN ticket does not
  • VULN-136573: CVE mismatch - Commit has CVE-2025-1234556789 but VULN ticket does not
  • VULN-136573: Status is 'To Do', expected 'In Progress'
  • VULN-136573: LTS product 'lts-8.6' expects branch 'ciqlts8_6', but merge target is 'fips-8-compliant/4.18.0-553.16.1'

⚠️ Warnings:

  • VULN-136573: No time logged - please log time manually

Commit f631fe5b7fff

Summary: sctp: linearize cloned gso packets in sctp_rcv

❌ Errors:

  • VULN-136339: Status is 'To Do', expected 'In Progress'

Commit 104675413a08

Summary: net_sched: hfsc: Fix a UAF vulnerability in class handling

⚠️ Warnings:

  • VULN-67697: No time logged - please log time manually

Summary: Checked 4 commit(s) total.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR contains VULN tickets that do not match the target LTS product. Please review the JIRA ticket assignments and ensure they match the merge target branch.

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

JIRA PR Check Results

3 commit(s) with issues found:

Commit 2621a890be52

Summary: NFS: Fix filehandle bounds checking in nfs_fh_to_dentry()

❌ Errors:

  • VULN-136575: CVE mismatch - Commit has CVE-2025-1234556789 but VULN ticket does not
  • VULN-136574: CVE mismatch - Commit has CVE-2025-1234556789 but VULN ticket does not
  • VULN-136573: CVE mismatch - Commit has CVE-2025-1234556789 but VULN ticket does not
  • VULN-136573: Status is 'To Do', expected 'In Progress'
  • VULN-136573: LTS product 'lts-8.6' expects branch 'ciqlts8_6', but merge target is 'fips-8-compliant/4.18.0-553.16.1'

⚠️ Warnings:

  • VULN-136573: No time logged - please log time manually

Commit f631fe5b7fff

Summary: sctp: linearize cloned gso packets in sctp_rcv

❌ Errors:

  • VULN-136339: Status is 'To Do', expected 'In Progress'

Commit 104675413a08

Summary: net_sched: hfsc: Fix a UAF vulnerability in class handling

⚠️ Warnings:

  • VULN-67697: No time logged - please log time manually

Summary: Checked 7 commit(s) total.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR contains VULN tickets that do not match the target LTS product. Please review the JIRA ticket assignments and ensure they match the merge target branch.

We are going to use this github action to do all the PR git commit
processing. Since the kernel-src-tree is so large we need to minimize
the wasted cycles on common checkout actions.
We will be reaching into our JIRA to check the state of each commits
jira.  In this we want to ensure that the target branch matches the
defined branch for that product and validate that the CVE ID is also
correct for the ticket.  It will also check to confirm that the tickets
are in progress and have time logged, if either are untrue then it will
produce a warning.

In the event there are Product or CVE mis matches it will block the PR
and request changes.
@PlaidCat PlaidCat force-pushed the {jmaple}_fips-8-compliant/4.18.0-553.16.1 branch from a145ba6 to 487b0da Compare October 10, 2025 00:39
@github-actions
Copy link

JIRA PR Check Results

3 commit(s) with issues found:

Commit 2621a890be52

Summary: NFS: Fix filehandle bounds checking in nfs_fh_to_dentry()

❌ Errors:

  • VULN-136575: CVE mismatch - Commit has CVE-2025-1234556789 but VULN ticket does not
  • VULN-136574: CVE mismatch - Commit has CVE-2025-1234556789 but VULN ticket does not
  • VULN-136573: CVE mismatch - Commit has CVE-2025-1234556789 but VULN ticket does not
  • VULN-136573: Status is 'To Do', expected 'In Progress'
  • VULN-136573: LTS product 'lts-8.6' expects branch 'ciqlts8_6', but merge target is 'fips-8-compliant/4.18.0-553.16.1'

⚠️ Warnings:

  • VULN-136573: No time logged - please log time manually

Commit f631fe5b7fff

Summary: sctp: linearize cloned gso packets in sctp_rcv

❌ Errors:

  • VULN-136339: Status is 'To Do', expected 'In Progress'

Commit 104675413a08

Summary: net_sched: hfsc: Fix a UAF vulnerability in class handling

⚠️ Warnings:

  • VULN-67697: No time logged - please log time manually

Summary: Checked 5 commit(s) total.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR contains VULN tickets that do not match the target LTS product. Please review the JIRA ticket assignments and ensure they match the merge target branch.

jira VULN-70726
jira VULN-70725
cve CVE-2022-50228
commit-author Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
commit f17c31c

Don't BUG/WARN on interrupt injection due to GIF being cleared,
since it's trivial for userspace to force the situation via
KVM_SET_VCPU_EVENTS (even if having at least a WARN there would be correct
for KVM internally generated injections).

  kernel BUG at arch/x86/kvm/svm/svm.c:3386!
  invalid opcode: 0000 [#1] SMP
  CPU: 15 PID: 926 Comm: smm_test Not tainted 5.17.0-rc3+ #264
  Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015
  RIP: 0010:svm_inject_irq+0xab/0xb0 [kvm_amd]
  Code: <0f> 0b 0f 1f 00 0f 1f 44 00 00 80 3d ac b3 01 00 00 55 48 89 f5 53
  RSP: 0018:ffffc90000b37d88 EFLAGS: 00010246
  RAX: 0000000000000000 RBX: ffff88810a234ac0 RCX: 0000000000000006
  RDX: 0000000000000000 RSI: ffffc90000b37df7 RDI: ffff88810a234ac0
  RBP: ffffc90000b37df7 R08: ffff88810a1fa410 R09: 0000000000000000
  R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
  R13: ffff888109571000 R14: ffff88810a234ac0 R15: 0000000000000000
  FS:  0000000001821380(0000) GS:ffff88846fdc0000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 00007f74fc550008 CR3: 000000010a6fe000 CR4: 0000000000350ea0
  Call Trace:
   <TASK>
   inject_pending_event+0x2f7/0x4c0 [kvm]
   kvm_arch_vcpu_ioctl_run+0x791/0x17a0 [kvm]
   kvm_vcpu_ioctl+0x26d/0x650 [kvm]
   __x64_sys_ioctl+0x82/0xb0
   do_syscall_64+0x3b/0xc0
   entry_SYSCALL_64_after_hwframe+0x44/0xae
   </TASK>

Fixes: 219b65d ("KVM: SVM: Improve nested interrupt injection")
	Cc: stable@vger.kernel.org
Co-developed-by: Sean Christopherson <seanjc@google.com>
	Signed-off-by: Sean Christopherson <seanjc@google.com>
	Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
Message-Id: <35426af6e123cbe91ec7ce5132ce72521f02b1b5.1651440202.git.maciej.szmigiero@oracle.com>
	Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit f17c31c)
	Signed-off-by: Jonathan Maple <jmaple@ciq.com>
jira VULN-155018
jira VULN-155017
cve CVE-2023-53305
commit-author Zhengping Jiang <jiangzp@google.com>
commit f752a0b

Fix potential use-after-free in l2cap_le_command_rej.

	Signed-off-by: Zhengping Jiang <jiangzp@google.com>
	Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
	Signed-off-by: Jakub Kicinski <kuba@kernel.org>
(cherry picked from commit f752a0b)
	Signed-off-by: Jonathan Maple <jmaple@ciq.com>
jira VULN-155734
jira VULN-155733
cve CVE-2023-53373
commit-author Herbert Xu <herbert@gondor.apana.org.au>
commit 32e6202

As it is seqiv only handles the special return value of EINPROGERSS,
which means that in all other cases it will free data related to the
request.

However, as the caller of seqiv may specify MAY_BACKLOG, we also need
to expect EBUSY and treat it in the same way.  Otherwise backlogged
requests will trigger a use-after-free.

Fixes: 0a27032 ("[CRYPTO] seqiv: Add Sequence Number IV Generator")
	Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
(cherry picked from commit 32e6202)
	Signed-off-by: Jonathan Maple <jmaple@ciq.com>
jira VULN-152896
jira VULN-152895
cve CVE-2025-39751
commit-author Lucy Thrun <lucy.thrun@digital-rabbithole.de>
commit a409c60

The 'sprintf' call in 'add_tuning_control' may exceed the 44-byte
buffer if either string argument is too long. This triggers a compiler
warning.
Replaced 'sprintf' with 'snprintf' to limit string lengths to prevent
overflow.

	Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506100642.95jpuMY1-lkp@intel.com/
	Signed-off-by: Lucy Thrun <lucy.thrun@digital-rabbithole.de>
Link: https://patch.msgid.link/20250610175012.918-3-lucy.thrun@digital-rabbithole.de
	Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit a409c60)
	Signed-off-by: Jonathan Maple <jmaple@ciq.com>
jira VULN-152934
jira VULN-152933
cve CVE-2025-39757
commit-author Takashi Iwai <tiwai@suse.de>
commit ecfd411

UAC3 class segment descriptors need to be verified whether their sizes
match with the declared lengths and whether they fit with the
allocated buffer sizes, too.  Otherwise malicious firmware may lead to
the unexpected OOB accesses.

Fixes: 11785ef ("ALSA: usb-audio: Initial Power Domain support")
Reported-and-tested-by: Youngjun Lee <yjjuny.lee@samsung.com>
	Cc: <stable@vger.kernel.org>
Link: https://patch.msgid.link/20250814081245.8902-2-tiwai@suse.de
	Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit ecfd411)
	Signed-off-by: Jonathan Maple <jmaple@ciq.com>
@github-actions
Copy link

🔍 Upstream Linux Kernel Commit Check

  • ⚠️ PR commit a0db3bb4c1c4 (ALSA: usb-audio: Validate UAC3 cluster segment descriptors) references upstream commit
    ecfd41166b72 which has been referenced by a Fixes: tag in the upstream
    Linux kernel:
    89f0addeee3c ALSA: usb-audio: Fix size validation in convert_chmap_v3() (Dan Carpenter)

This is an automated message from the kernel commit checker workflow.

@github-actions
Copy link

JIRA PR Check Results

8 commit(s) with issues found:

Commit a0db3bb4c1c4

Summary: ALSA: usb-audio: Validate UAC3 cluster segment descriptors

❌ Errors:

  • VULN-152934: Status is 'To Do', expected 'In Progress'
  • VULN-152933: Status is 'To Do', expected 'In Progress'

⚠️ Warnings:

  • VULN-152934: No time logged - please log time manually
  • VULN-152933: No time logged - please log time manually

Commit 346b76270991

Summary: ALSA: hda/ca0132: Fix buffer overflow in add_tuning_control

❌ Errors:

  • VULN-152896: Status is 'To Do', expected 'In Progress'
  • VULN-152895: Status is 'To Do', expected 'In Progress'

⚠️ Warnings:

  • VULN-152896: No time logged - please log time manually
  • VULN-152895: No time logged - please log time manually

Commit 0a6d91dd7486

Summary: crypto: seqiv - Handle EBUSY correctly

❌ Errors:

  • VULN-155734: Status is 'To Do', expected 'In Progress'
  • VULN-155733: Status is 'To Do', expected 'In Progress'

⚠️ Warnings:

  • VULN-155734: No time logged - please log time manually
  • VULN-155733: No time logged - please log time manually

Commit fe3dacef2d4e

Summary: Bluetooth: L2CAP: Fix use-after-free

❌ Errors:

  • VULN-155018: Status is 'To Do', expected 'In Progress'
  • VULN-155017: Status is 'To Do', expected 'In Progress'

⚠️ Warnings:

  • VULN-155018: No time logged - please log time manually
  • VULN-155017: No time logged - please log time manually

Commit 4c854209e160

Summary: KVM: SVM: Don't BUG if userspace injects an interrupt with GIF=0

❌ Errors:

  • VULN-70726: Status is 'To Do', expected 'In Progress'
  • VULN-70725: Status is 'To Do', expected 'In Progress'

⚠️ Warnings:

  • VULN-70726: No time logged - please log time manually
  • VULN-70725: No time logged - please log time manually

Commit 2621a890be52

Summary: NFS: Fix filehandle bounds checking in nfs_fh_to_dentry()

❌ Errors:

  • VULN-136575: CVE mismatch - Commit has CVE-2025-1234556789 but VULN ticket does not
  • VULN-136574: CVE mismatch - Commit has CVE-2025-1234556789 but VULN ticket does not
  • VULN-136573: CVE mismatch - Commit has CVE-2025-1234556789 but VULN ticket does not
  • VULN-136573: Status is 'To Do', expected 'In Progress'
  • VULN-136573: LTS product 'lts-8.6' expects branch 'ciqlts8_6', but merge target is 'fips-8-compliant/4.18.0-553.16.1'

⚠️ Warnings:

  • VULN-136573: No time logged - please log time manually

Commit f631fe5b7fff

Summary: sctp: linearize cloned gso packets in sctp_rcv

❌ Errors:

  • VULN-136339: Status is 'To Do', expected 'In Progress'

Commit 104675413a08

Summary: net_sched: hfsc: Fix a UAF vulnerability in class handling

⚠️ Warnings:

  • VULN-67697: No time logged - please log time manually

Summary: Checked 10 commit(s) total.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR contains VULN tickets that do not match the target LTS product. Please review the JIRA ticket assignments and ensure they match the merge target branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant