fix single package tag #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 0bca11a This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
pablomendezroyo
approved these changes
Oct 27, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the git tag generation logic for single-package releases by checking the multi-variant flag earlier in the function, preventing incorrect tag formats for single-variant packages.
Key Changes:
- Moved the single-variant check earlier in the function execution flow
- Added an explicit check for
!isMultiVariantflag in the single-variant condition
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pablomendezroyo
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes single package tags
https://github.com/dappnode/DNP_NOTIFICATIONS/actions/runs/18772403970/job/53559427854