Skip to content

fix single package tag #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablomendezroyo merged 2 commits into from
Oct 27, 2025
Merged

fix single package tag #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18cd9fa
fix single package tag
Marketen Oct 27, 2025
0bca11a
add unit testing
pablomendezroyo Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/tasks/createGithubRelease/getNextGitTag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ export function getNextGitTag(releaseDetailsMap: GitTagDetailsMap, isMultiVarian
if (variantVersions.length === 0)
throw Error("Could not generate git tag. Missing variant or nextVersion");

// If not multi-variant and only one variant, return v<version>
if (variantVersions.length === 1 && !isMultiVariant)
return `v${variantVersions[0].nextVersion}`;

// If any variant is null, throw an error
if (variantVersions.some(({ variant }) => !variant))
throw Error("Could not generate git tag. Missing variant");
Expand All @@ -39,9 +43,6 @@ export function getNextGitTag(releaseDetailsMap: GitTagDetailsMap, isMultiVarian
.join("_");
}

// Not a multi-variant package
if (variantVersions.length === 1) return `v${variantVersions[0].nextVersion}`;

// Multi-variant package (fallback, should not hit if isMultiVariant is set correctly)
return variantVersions
.sort((a, b) => (a.variant || "").localeCompare(b.variant || ""))
Expand Down
20 changes: 20 additions & 0 deletions test/tasks/gitTags.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,26 @@ describe("getNextGitTag", () => {
expect(result).to.equal("v0.1.2");
});

it("should not throw an error if single variant is missing (not multi-variant)", () => {
const ctx = {
"geth.dnp.dapnode.eth": {
variant: null,
nextVersion: "0.1.2"
}
};
expect(() => getNextGitTag(ctx, false)).to.not.throw()
});

it("should throw an error if single variant is missing (multi-variant)", () => {
const ctx = {
"geth.dnp.dapnode.eth": {
variant: null,
nextVersion: "0.1.2"
}
};
expect(() => getNextGitTag(ctx, true)).to.throw("Could not generate git tag. Missing variant");
});

it("should format a single-variant package as variant@v<version> if isMultiVariant is true", () => {
const ctx = {
"gnosis.dnp.dapnode.eth": {
Expand Down
Loading