Skip to content

Conversation

@asikowitz
Copy link
Collaborator

@asikowitz asikowitz commented Nov 14, 2025

#15084 got merged which I believe incorrectly implements what I assume was the desired goal, i.e. using logo url over hard-coded image on this component. We shouldn't need resolve runtime path here and should not be passing in img urls like that anyway.

Should I also remove this from BASE_PATH.md?

### For Asset URLs

Use the `resolveRuntimePath()` function to resolve any asset path:

```typescript
import { resolveRuntimePath } from '../utils/runtimeBasePath';

// Resolve asset paths
const logoUrl = resolveRuntimePath('/assets/logo.png');
const apiUrl = resolveRuntimePath('/api/graphql');

// Use in components
<img src={resolveRuntimePath('/assets/icons/favicon.ico')} alt="DataHub" />

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Nov 14, 2025

✅ Meticulous spotted visual differences in 20 of 1024 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 757de24. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Nov 14, 2025

Bundle Report

Changes will decrease total bundle size by 28 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.64MB -28 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -28 bytes 19.01MB -0.0%

Files in assets/index-*.js:

  • ./src/app/shared/error/ErrorSection.tsx → Total Size: 2.49kB

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@asikowitz asikowitz merged commit cf326ee into master Nov 18, 2025
41 checks passed
@asikowitz asikowitz deleted the fix-error-section-img branch November 18, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants