use default field for default test path #2574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
force-pushed
the
fix-PATH
branch
2 times, most recently
from
95e4f19 to
9d3735a
Compare
Pankraz76
commented
Jul 23, 2025
testlib/src/main/java/com/diffplug/spotless/ResourceHarness.java
Outdated
Show resolved
Hide resolved
|
If we expect more constants like this to be reused across classes, it might be worth adding TestConstants class. |
|
@Pankraz76 |
Pankraz76
force-pushed
the
fix-PATH
branch
5 times, most recently
from
2e5c5ba to
12f5197
Compare
iddeepak
approved these changes
Jul 23, 2025
nedtwigg
requested changes
Jul 24, 2025
Comment on lines
+46
to
+49
| /** | ||
| * default test testPath. | ||
| */ | ||
| protected String testPath = "src/main/java/test.java"; |
There was a problem hiding this comment.
Mutable state is bad. Before this PR, it might be possible to enable method-level parallelism, after this PR it is definitely impossible. For Spotless we prefer functional style whenever possible.
There was a problem hiding this comment.
agree, lets make the field final.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consolidating common field access.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)
@iddeepak
if this is acceptable then i would update changed as well.