Skip to content

give SSOT/SPOT on default field TEST_PATH to avoid DRY #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Pankraz76
Copy link
Contributor

After creating the PR, please add a commit that adds a bullet-point under the [Unreleased] section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the plugin-foo/CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

@Pankraz76 Pankraz76 marked this pull request as ready for review July 24, 2025 08:37
@Pankraz76 Pankraz76 changed the title give SPOT on default field TEST_PATH to avoid DRY give SSOT/SPOT on default field TEST_PATH to avoid DRY Jul 24, 2025
@Pankraz76
Copy link
Contributor Author

Pankraz76 commented Jul 24, 2025

@ideepak @nedtwigg kindly request your feedback.

@nedtwigg
Copy link
Member

This does not reduce complexity in a meaningful way. It is okay for the string constant to be different in each test, there's no magic to its name.

I am not interested in stylistic cleanup PRs. If a PR changes lots of lines, it needs to either

  • be a deep simplification (not superficial)
  • add a significant new feature with a large end user base

@nedtwigg nedtwigg closed this Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants