-
Notifications
You must be signed in to change notification settings - Fork 10
Create an super admins team and switch admins to moderators #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Terraform plan in terraform Plan: 2 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
!~ update in-place
Terraform will perform the following actions:
# github_team.org_teams["Admins"] will be updated in-place
!~ resource "github_team" "org_teams" {
!~ description = "django-commons administrators" -> "django-commons administrators team with moderator permissions in the org."
id = "9763562"
name = "Admins"
# (10 unchanged attributes hidden)
}
# github_team.org_teams["operations"] will be created
+ resource "github_team" "org_teams" {
+ create_default_maintainer = false
+ description = "django-commons operations team with admin permissions in the org."
+ etag = (known after apply)
+ id = (known after apply)
+ members_count = (known after apply)
+ name = "operations"
+ node_id = (known after apply)
+ parent_team_read_id = (known after apply)
+ parent_team_read_slug = (known after apply)
+ privacy = "closed"
+ slug = (known after apply)
}
# github_team_members.org_team_members["operations"] will be created
+ resource "github_team_members" "org_team_members" {
+ id = (known after apply)
+ team_id = (known after apply)
+ members {
+ role = "maintainer"
+ username = "Stormheg"
}
+ members {
+ role = "maintainer"
+ username = "cunla"
}
+ members {
+ role = "maintainer"
+ username = "ryancheley"
}
+ members {
+ role = "maintainer"
+ username = "tim-schilling"
}
+ members {
+ role = "maintainer"
+ username = "williln"
}
}
Plan: 2 to add, 1 to change, 0 to destroy.📝 Plan generated in Plan org changes and list them in a PR #226 |
|
Yeah, I think we may want to split this into two PRs. Create the ops team first, then reduce the admin team's permissions. Please hold. |
bcf100c to
dd03789
Compare
5dee196 to
f0c0259
Compare
|
These commits should be squashed on merge and the commit message updated to match the super admin language rather than ops team. |
The operations team will have admin permissions in the GitHub org while the admins team will have moderator permissions. This needs to be followed up with another commit to reduce the permissions of the org admins teams to member. This is being split up to avoid removing all admin permissions.
f0c0259 to
9de3659
Compare
The super admins team will have admin permissions in the GitHub org while the admins team will have moderator permissions.
Closes django-commons/controls#90
We need to confirm we're not all going to lose our permissions with this change 😬