add support for including private Slack channels in slack source #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djudjuu
reviewed
Jul 29, 2025
mypy.ini
Outdated
| @@ -1,5 +1,5 @@ | |||
| [mypy] | |||
| python_version=3.8 | |||
| python_version=3.9 | |||
There was a problem hiding this comment.
The CI was failing because a file inside the dlt package (postgres.py) uses parenthesized context managers a syntax that’s only valid in Python 3.9 and above
packages/dlt/destinations/impl/postgres/postgres.py:86: error: Parenthesized context managers are only supported in Python 3.9 and greater [syntax]
…into enh/slack_include_private_channels
VioletM
previously approved these changes
Aug 4, 2025
tests/slack/test_slack_source.py
Outdated
| ) | ||
|
|
||
| assert expected_message_table_name in table_names | ||
| assert expected_replies_table_name in table_names |
There was a problem hiding this comment.
Will this table be created if we have zero messages available?
There was a problem hiding this comment.
ah, because in three months the old messages will go away..good point. i guess we don't really need the replies test here
Co-authored-by: Violetta Mishechkina <sansiositres@gmail.com>
Co-authored-by: Violetta Mishechkina <sansiositres@gmail.com>
VioletM
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enh: add support for including private Slack channels in source
include_private_channelsparameter toslack_source