-
Notifications
You must be signed in to change notification settings - Fork 68
add support for including private Slack channels in slack source #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
48e801b
add support for including private Slack channels in slack source
molkazhani2001 c0e6344
fixing lint issues
molkazhani2001 deaf63b
update mypy config
molkazhani2001 c5ffe48
add test for private channel + adding dynamic dates
molkazhani2001 ff36918
Merge branch 'master' of https://github.com/dlt-hub/verified-sources …
molkazhani2001 bf429f7
fix tests
djudjuu 9c7e2ef
better tests
djudjuu 68054e5
correct imported
djudjuu f5639d7
Update tests/slack/test_slack_source.py
djudjuu 93b5fc1
remove replies from private channel test
djudjuu 594be17
fix tests
djudjuu c35c012
Update sources/slack_pipeline.py
djudjuu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI was failing because a file inside the dlt package (postgres.py) uses parenthesized context managers a syntax that’s only valid in Python 3.9 and above
packages/dlt/destinations/impl/postgres/postgres.py:86: error: Parenthesized context managers are only supported in Python 3.9 and greater [syntax]