Make "bookmark added" dialog specific to that use case #7099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CDRussell
force-pushed
the
feature/craig/make_bookmark_added_dialog_less_generic
branch
from
2b3bf02 to
85c38e1
Compare
CDRussell
force-pushed
the
feature/craig/make_bookmark_added_dialog_less_generic
branch
from
85c38e1 to
df9820c
Compare
CDRussell
force-pushed
the
feature/craig/make_bookmark_added_dialog_less_generic
branch
2 times, most recently
from
ca118be to
4ab4dbf
Compare
18 tasks
CDRussell
force-pushed
the
feature/craig/make_bookmark_added_dialog_less_generic
branch
from
4ab4dbf to
9158c48
Compare
CrisBarreiro
approved these changes
Nov 18, 2025
| private val bookmarkFolder: BookmarkFolder?, | ||
| ) : BottomSheetDialog(context) { | ||
|
|
||
| abstract class EventListener { |
Contributor
There was a problem hiding this comment.
nit: why not an interface?
Member
Author
There was a problem hiding this comment.
I would normally go for interface personally, but this was porting over existing code (renaming the dialog) so wanted to minimize changes made. It also seems to be fairly consistent with other dialogs/builders, so I just kept it as it was.
CDRussell
force-pushed
the
feature/craig/make_bookmark_added_dialog_less_generic
branch
from
9158c48 to
ce58927
Compare
Member
Author
Merge activity
|
CDRussell
deleted the
feature/craig/make_bookmark_added_dialog_less_generic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1208273769335188/task/1211910160515992?focus=true
Description
This is taking
BookmarksBottomSheetDialog, which is generic but only ever used for a specific use case (bookmark added confirmation) and just making it specific to that use case. This simplifies it as well as better preparing it for extension to support adding an option to let users know they can enable sync.BookmarksBottomSheetDialog-->BookmarkAddedConfirmationDialogStrings moving to the correct module is done in #7127 to de-noise this one..
Steps to test this PR
Auto-dismisses
Add Bookmark.Edit Bookmarkand delete itEdit (not as favorite)
Add Bookmarkagain, don't toggle theAdd to Favoritesbut do tap onEdit Bookmark. Verify it isn't marked as favorite.Edit (when a favorite)
Add Bookmarkagain, this time toggle theAdd to Favoritesto enabledEdit Bookmark. Verify it is still marked as a favorite.