Skip to content

Conversation

martinRenou
Copy link
Contributor

This will help fixing jupyterlite/xeus#237, issue noticed in practice in compiler-research/xeus-cpp#357

This is a breaking change, we should make a major release with it

@martinRenou martinRenou added the enhancement New feature or request label Jun 27, 2025
@martinRenou
Copy link
Contributor Author

@DerThorsten does it look good to you?

It seems to me it'd be impossible to get the CI green on this PR since:

  • it requires an updated pyjs that supports this new entry in the empack lock
  • we'd need to release this PR before we can update pyjs

@martinRenou
Copy link
Contributor Author

emscripten-forge/pyjs#104 for the pyjs fix

emscripten-forge/mambajs#105 for the mambajs fix

@DerThorsten
Copy link
Collaborator

@DerThorsten does it look good to you?

It seems to me it'd be impossible to get the CI green on this PR since:

  • it requires an updated pyjs that supports this new entry in the empack lock
  • we'd need to release this PR before we can update pyjs

jeah, I think its fine to merge things even with breaking the CI.
A CI should help us and not be in our way...so I am fine with whatever is needed ;)

@martinRenou
Copy link
Contributor Author

So do you think we're good to merge this and make a major release?

@DerThorsten
Copy link
Collaborator

So do you think we're good to merge this and make a major release?

Yes

@martinRenou martinRenou merged commit 3d96b77 into emscripten-forge:main Jun 30, 2025
3 of 4 checks passed
@martinRenou martinRenou deleted the fix_mount_points branch June 30, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants