Skip to content

Update to new empack mount points #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 3, 2025
Merged

Update to new empack mount points #104

merged 6 commits into from
Jul 3, 2025

Conversation

martinRenou
Copy link
Contributor

@martinRenou martinRenou mentioned this pull request Jun 27, 2025
Merged
DerThorsten
DerThorsten requested changes Jun 30, 2025
View reviewed changes
@martinRenou
Copy link
Contributor Author

@DerThorsten are you sure about your latest commit? It was packages before, not all_packages, since all_packages contains Python and we don't want to load its shared libs at this point?

@DerThorsten
Copy link
Collaborator

Packages seemed to be undefined in the ci...I was a bit optimistic with my "fix"

@DerThorsten
Copy link
Collaborator

@martinRenou ... your fix seems more like the correct thing =)

@martinRenou
Copy link
Contributor Author

I think I found the actual culprit :D

@martinRenou martinRenou marked this pull request as ready for review July 3, 2025 09:07
@DerThorsten DerThorsten merged commit fa64593 into emscripten-forge:main Jul 3, 2025
3 checks passed
@DerThorsten
Copy link
Collaborator

thanks!

@martinRenou martinRenou deleted the up_empack branch July 3, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DerThorsten DerThorsten DerThorsten requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martinRenou @DerThorsten