Skip to content

Conversation

gitpushoriginmaster
Copy link

Summary

When seeing an unofficial status code the suggested further reading link to MDN Web Docs will be broken since it contains only official codes.

As an example, the unofficial code for 529 will direct the developer to https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/529, a web page that does not exist.

The change adds the line with the link only if the status code has a reason phrase, meaning it is a part of the 'codes' Enum.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
    • There are no message tests for raise_for_status.
  • I've updated the documentation accordingly.
    • No behavioral change, so no documentation to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant