Skip to content

Improve error message formatting in Response class to not give a link for unofficial codes. #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve error message formatting in Response class to not give a link for unofficial codes. #3612

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61a6a02
Improve error message formatting in Response class to not give a link…
gitpushoriginmaster Jul 21, 2025
ff7e4e2
Merge branch 'master' into master
gitpushoriginmaster Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions httpx/_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,17 +805,11 @@ def raise_for_status(self) -> Response:
if self.is_success:
return self

message = "{error_type} '{0.status_code} {0.reason_phrase}' for url '{0.url}'"
if self.has_redirect_location:
message = (
"{error_type} '{0.status_code} {0.reason_phrase}' for url '{0.url}'\n"
"Redirect location: '{0.headers[location]}'\n"
"For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/{0.status_code}"
)
else:
message = (
"{error_type} '{0.status_code} {0.reason_phrase}' for url '{0.url}'\n"
"For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/{0.status_code}"
)
message += "\nRedirect location: '{0.headers[location]}'"
if self.reason_phrase:
message += "\nFor more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/{0.status_code}"

status_class = self.status_code // 100
error_types = {
Expand Down